Skip to content

Conversation

@artembelik
Copy link
Contributor

@artembelik artembelik commented Sep 1, 2025

@artembelik artembelik self-assigned this Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Visit the preview URL for this PR (updated for commit db781ba):

https://koobiq-next--prs-999-jrl42h4w.web.app

(expires Tue, 16 Sep 2025 08:38:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@lskramarov lskramarov changed the base branch from main to feat/DS-4091 September 2, 2025 13:30
Base automatically changed from feat/DS-4091 to main September 4, 2025 09:35
@artembelik artembelik marked this pull request as ready for review September 4, 2025 14:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new KbqFieldSizingContent directive to implement auto-sizing functionality for input fields, replacing the CSS field-sizing: content property for better browser compatibility. The directive emulates this CSS property behavior for browsers that don't support it natively.

  • Added KbqFieldSizingContent directive to the core module with auto-sizing logic
  • Integrated the directive as a host directive for KbqTagEditInput to enable auto-sizing in tag edit inputs
  • Updated tag examples to use kbqInput directive for proper styling and functionality

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/components/core/form-field/field-sizing-content.ts New directive implementing field-sizing: content emulation with DOM manipulation
packages/components/core/utils/dom.ts New utility functions for injecting ElementRef and native elements
packages/components/tags/tag.component.ts Refactored to use injection for ElementRef and integrated KbqFieldSizingContent
packages/components/tags/tag.scss Updated styles to work with the new auto-sizing approach
packages/docs-examples/components/tag/* Added kbqInput directive to tag edit inputs in examples
tools/public_api_guard/components/*.api.md Updated API signatures to reflect changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rmnturov
Copy link
Contributor

rmnturov commented Sep 8, 2025

После сохранения длинный текст должен выравниваеться по левой стороне внутри тега, если что обрезаться справа.

Сейчас в теге длинный текст выровнен по правой стороне — это неправильно

tag-input-save-bug.mp4

Правильное положение
изображение

А в момент редактирования верно, что уходит направо
изображение

@artembelik
Copy link
Contributor Author

После сохранения длинный текст должен выравниваеться по левой стороне внутри тега, если что обрезаться справа.

поправил

NikGurev

This comment was marked as duplicate.

@artembelik artembelik merged commit d6d45cb into main Sep 12, 2025
4 checks passed
@artembelik artembelik deleted the feat/DS-4146 branch September 12, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants