-
Notifications
You must be signed in to change notification settings - Fork 3
feat(tags,core): added KbqFieldSizingContent directive (#DS-4146) #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit db781ba): https://koobiq-next--prs-999-jrl42h4w.web.app (expires Tue, 16 Sep 2025 08:38:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
a0eb2be to
cb9631d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new KbqFieldSizingContent directive to implement auto-sizing functionality for input fields, replacing the CSS field-sizing: content property for better browser compatibility. The directive emulates this CSS property behavior for browsers that don't support it natively.
- Added
KbqFieldSizingContentdirective to the core module with auto-sizing logic - Integrated the directive as a host directive for
KbqTagEditInputto enable auto-sizing in tag edit inputs - Updated tag examples to use
kbqInputdirective for proper styling and functionality
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/components/core/form-field/field-sizing-content.ts |
New directive implementing field-sizing: content emulation with DOM manipulation |
packages/components/core/utils/dom.ts |
New utility functions for injecting ElementRef and native elements |
packages/components/tags/tag.component.ts |
Refactored to use injection for ElementRef and integrated KbqFieldSizingContent |
packages/components/tags/tag.scss |
Updated styles to work with the new auto-sizing approach |
packages/docs-examples/components/tag/* |
Added kbqInput directive to tag edit inputs in examples |
tools/public_api_guard/components/*.api.md |
Updated API signatures to reflect changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
поправил |


should be merged after #987
todo: