feat(ag-grid-angular-theme): added shadows for pinned columns (#DS-4581)#145
feat(ag-grid-angular-theme): added shadows for pinned columns (#DS-4581)#145artembelik merged 10 commits intomainfrom
Conversation
|
Visit the preview URL for this PR (updated for commit 0f01f6e): https://data-grid-next--data-grid-pr-145-qo9m4fs0.web.app (expires Sat, 28 Mar 2026 11:24:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
artembelik
force-pushed
the
feat/DS-4581
branch
from
81c91bc to
c87ff86
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
There was a problem hiding this comment.
Pull request overview
Adds visual shadows for AG Grid pinned columns when the horizontal viewport is overflowed, wiring the theme CSS to runtime overflow detection and updating Playwright screenshots accordingly.
Changes:
- Replace pinned-column border styling with conditional box-shadows in the SCSS theme.
- Add overflow detection to
KbqAgGridThemeand bind overflow state to host classes. - Update Playwright E2E to scroll before taking pinned-columns screenshots and refresh snapshot assets.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/ag-grid-angular-theme/theme.scss | Applies conditional pinned-column shadows based on new overflow classes. |
| packages/ag-grid-angular-theme/module.ng.ts | Adds signals + scroll observation to toggle overflow classes on the grid host. |
| dev/ag-grid-angular/src/app.playwright-spec.ts | Scrolls the grid before screenshot assertions for pinned columns. |
| dev/ag-grid-angular/src/screenshots/03-light.png | Updated snapshot reflecting new styling. |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
No description provided.