feat(Table): add data attributes to sort icon wrapper (DS-5214)#411
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 29ebbf0): https://react-koobiq-next--prs-411-1nvq1bye.web.app (expires Wed, 08 Jul 2026 14:14:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
This PR enhances the Table component’s sortable column header by exposing stable data-* attributes on the sort icon wrapper, making it easier to target via styling/tests and to reflect the active sort direction.
Changes:
- Add
data-slot="sort-icon"and conditionaldata-sort-directionto the sort icon wrapper inTableColumnHeader. - Update
Tabletests to validate the presence/absence ofdata-sort-directiondepending on active sorting state. - Adjust the sort icon CSS “active” selector to use
:where(.active).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/components/src/components/Table/Table.test.tsx | Updates assertions to verify new data-* attributes on the sort icon wrapper. |
| packages/components/src/components/Table/components/TableColumnHeader/TableColumnHeader.tsx | Adds data-slot and data-sort-direction attributes to the sort icon wrapper element. |
| packages/components/src/components/Table/components/TableColumnHeader/TableColumnHeader.module.css | Tweaks the .active selector for the sort icon to use :where(.active). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.