Skip to content

feat(Table): add data attributes to sort icon wrapper (DS-5214)#411

Merged
KamilEmeleev merged 1 commit into
mainfrom
feat/ds-5214
Jul 6, 2026
Merged

feat(Table): add data attributes to sort icon wrapper (DS-5214)#411
KamilEmeleev merged 1 commit into
mainfrom
feat/ds-5214

Conversation

@KamilEmeleev

Copy link
Copy Markdown
Collaborator

No description provided.

@KamilEmeleev KamilEmeleev added the enhancement New feature or request label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 29ebbf0):

https://react-koobiq-next--prs-411-1nvq1bye.web.app

(expires Wed, 08 Jul 2026 14:14:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Table component’s sortable column header by exposing stable data-* attributes on the sort icon wrapper, making it easier to target via styling/tests and to reflect the active sort direction.

Changes:

  • Add data-slot="sort-icon" and conditional data-sort-direction to the sort icon wrapper in TableColumnHeader.
  • Update Table tests to validate the presence/absence of data-sort-direction depending on active sorting state.
  • Adjust the sort icon CSS “active” selector to use :where(.active).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/components/src/components/Table/Table.test.tsx Updates assertions to verify new data-* attributes on the sort icon wrapper.
packages/components/src/components/Table/components/TableColumnHeader/TableColumnHeader.tsx Adds data-slot and data-sort-direction attributes to the sort icon wrapper element.
packages/components/src/components/Table/components/TableColumnHeader/TableColumnHeader.module.css Tweaks the .active selector for the sort icon to use :where(.active).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/src/components/Table/Table.test.tsx
Comment thread packages/components/src/components/Table/Table.test.tsx
@KamilEmeleev KamilEmeleev merged commit 1965380 into main Jul 6, 2026
8 checks passed
@KamilEmeleev KamilEmeleev deleted the feat/ds-5214 branch July 6, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants