-
Notifications
You must be signed in to change notification settings - Fork 2
Add suport to PHP 8.0 and PHP 8.1 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lucassmacedo out Dockerfiles are auto generated running Is there any change in the images? Other than the base image? If so, just changing the https://github.com/kool-dev/docker-php-oci8/blob/main/fwd-template.json and running |
|
@dbpolito i'm doing a new pull request, there's no change besides the base image. |
|
Done. |
|
@lucassmacedo do you mind adding the non prod ones too? to follow the standard |
lucassmacedo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add suport to PHP 8.0 and PHP 8.1 in fwd-template file
|
also, you need to cleanup the 8.2 image, and the README |
|
Check now please. |
| ] | ||
| }, | ||
| { | ||
| "name": "8.0-nginx-oci8-prod", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add here without prod too... for both versions, and run template again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check now please.
Add suport to PHP 8.0 and PHP 8.1