Skip to content

Conversation

@lucassmacedo
Copy link
Contributor

Add suport to PHP 8.0 and PHP 8.1

@dbpolito
Copy link
Member

dbpolito commented Nov 7, 2022

@lucassmacedo out Dockerfiles are auto generated running kool run template, as described in the README: https://github.com/kool-dev/docker-php-oci8#update-images-with-templates

Is there any change in the images? Other than the base image? If so, just changing the https://github.com/kool-dev/docker-php-oci8/blob/main/fwd-template.json and running kool run template should do the job

@lucassmacedo
Copy link
Contributor Author

@dbpolito i'm doing a new pull request, there's no change besides the base image.

@lucassmacedo
Copy link
Contributor Author

Done.

@dbpolito
Copy link
Member

dbpolito commented Nov 7, 2022

@lucassmacedo do you mind adding the non prod ones too? to follow the standard

Copy link
Contributor Author

@lucassmacedo lucassmacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add suport to PHP 8.0 and PHP 8.1 in fwd-template file

@dbpolito
Copy link
Member

dbpolito commented Nov 7, 2022

also, you need to cleanup the 8.2 image, and the README

@lucassmacedo
Copy link
Contributor Author

Check now please.

]
},
{
"name": "8.0-nginx-oci8-prod",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add here without prod too... for both versions, and run template again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check now please.

@dbpolito dbpolito merged commit 4a3578c into kool-dev:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants