Skip to content

Conversation

@fabriciojs
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 16, 2025 13:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the Imagick PHP extension installation process across all PHP versions by replacing complex manual compilation steps with the standard pecl install method, and standardizes the php.ini configuration timing.

  • Replaces manual Imagick compilation (for PHP 8.3+) with simple pecl install imagick
  • Moves php.ini copy operation earlier in the Dockerfile build process
  • Simplifies nginx configuration by removing redundant $uri/ check and X-Served-By header

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
template/Dockerfile.blade.php Removes conditional Imagick compilation logic, uses pecl install for all versions, and moves php.ini setup earlier
template/default-tmpl.blade.php Simplifies nginx try_files directive and removes X-Served-By header
8.4/Dockerfile, 8.4-prod/Dockerfile Adds pecl install imagick and relocates php.ini copy
8.3/Dockerfile, 8.3-prod/Dockerfile Replaces manual Imagick compilation with pecl install and relocates php.ini copy
8.2/Dockerfile, 8.2-prod/Dockerfile Relocates php.ini copy to earlier in build process
8.1/Dockerfile, 8.1-prod/Dockerfile Relocates php.ini copy to earlier in build process
8.0/Dockerfile, 8.0-prod/Dockerfile Relocates php.ini copy to earlier in build process
8.-nginx/default.tmpl, 8.-nginx-prod/default.tmpl Simplifies nginx location block configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@fabriciojs fabriciojs merged commit 4b9682f into master Oct 16, 2025
@fabriciojs fabriciojs deleted the patch-imagick branch October 16, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants