feat(task): added new long task runner#170
Merged
fabriciojs merged 6 commits intokool-dev:masterfrom Oct 22, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 86.62% 89.32% +2.69%
==========================================
Files 49 50 +1
Lines 1563 1602 +39
==========================================
+ Hits 1354 1431 +77
+ Misses 190 145 -45
- Partials 19 26 +7
Continue to review full report at Codecov.
|
fabriciojs
requested changes
Oct 20, 2020
Member
fabriciojs
left a comment
There was a problem hiding this comment.
Awesome work on more test coverage!
Couple of comments, which I believe we should address 2 and other 2 we may leave for the next iteration on this!
fabriciojs
reviewed
Oct 21, 2020
fabriciojs
requested changes
Oct 22, 2020
Member
fabriciojs
left a comment
There was a problem hiding this comment.
Good job!
Two minor comments so we can merge this!
fabriciojs
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169