Skip to content

feat(task): added new long task runner#170

Merged
fabriciojs merged 6 commits intokool-dev:masterfrom
danielsuguimoto:task
Oct 22, 2020
Merged

feat(task): added new long task runner#170
fabriciojs merged 6 commits intokool-dev:masterfrom
danielsuguimoto:task

Conversation

@danielsuguimoto
Copy link
Copy Markdown
Contributor

Closes #169

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 19, 2020

Codecov Report

Merging #170 into master will increase coverage by 2.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   86.62%   89.32%   +2.69%     
==========================================
  Files          49       50       +1     
  Lines        1563     1602      +39     
==========================================
+ Hits         1354     1431      +77     
+ Misses        190      145      -45     
- Partials       19       26       +7     
Impacted Files Coverage Δ
cmd/docker.go 100.00% <100.00%> (ø)
cmd/exec.go 100.00% <100.00%> (ø)
cmd/fake_kool_service.go 100.00% <100.00%> (ø)
cmd/kool_service.go 100.00% <100.00%> (ø)
cmd/kool_task.go 100.00% <100.00%> (ø)
cmd/root.go 100.00% <100.00%> (ø)
cmd/self-update.go 100.00% <100.00%> (ø)
cmd/shell/fake_output_writer.go 100.00% <100.00%> (ø)
cmd/shell/output_writer.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473bb70...dc38d6a. Read the comment docs.

Copy link
Copy Markdown
Member

@fabriciojs fabriciojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on more test coverage!

Couple of comments, which I believe we should address 2 and other 2 we may leave for the next iteration on this!

Comment thread cmd/task/task.go Outdated
Comment thread cmd/task/task.go Outdated
Comment thread cmd/task/task.go Outdated
Comment thread cmd/self-update.go Outdated
Comment thread cmd/self-update.go Outdated
Copy link
Copy Markdown
Member

@fabriciojs fabriciojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Two minor comments so we can merge this!

Comment thread cmd/kool_task.go Outdated
Comment thread cmd/kool_task.go
@fabriciojs fabriciojs merged commit 9acc566 into kool-dev:master Oct 22, 2020
@danielsuguimoto danielsuguimoto deleted the task branch July 21, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve commands long tasks output

2 participants