Skip to content

feat(init): deprecating init command#177

Merged
fabriciojs merged 1 commit intokool-dev:masterfrom
danielsuguimoto:init_deprecated
Oct 22, 2020
Merged

feat(init): deprecating init command#177
fabriciojs merged 1 commit intokool-dev:masterfrom
danielsuguimoto:init_deprecated

Conversation

@danielsuguimoto
Copy link
Copy Markdown
Contributor

Relates to #11

This pull request brings back the init command, but deprecated and working as a proxy to the preset command, in case we need to release a new tag before 2.0.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 22, 2020

Codecov Report

Merging #177 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   86.62%   86.67%   +0.04%     
==========================================
  Files          49       50       +1     
  Lines        1563     1568       +5     
==========================================
+ Hits         1354     1359       +5     
  Misses        190      190              
  Partials       19       19              
Impacted Files Coverage Δ
cmd/init.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473bb70...61b3610. Read the comment docs.

@fabriciojs
Copy link
Copy Markdown
Member

@danielsuguimoto thanks! this is good so we can have 1.6.0 prior, and wait for 2.0 with other bigger changes - we should use major versions to really do most of the breaking changes we can at once :D

@fabriciojs fabriciojs merged commit 7b3023c into kool-dev:master Oct 22, 2020
@fabriciojs
Copy link
Copy Markdown
Member

@danielsuguimoto now that this one is on master, I will create master -> 2.0; after that, we should create a new PR removing the init proxy once again, so 2.0 do not keep it.

@danielsuguimoto danielsuguimoto deleted the init_deprecated branch November 30, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants