Prepend http protocol#9
Merged
fabriciojs merged 2 commits intokool-dev:masterfrom Nov 10, 2020
Merged
Conversation
fabriciojs
requested changes
Nov 9, 2020
Member
fabriciojs
left a comment
There was a problem hiding this comment.
Looks good! Just one comment.
| }); | ||
|
|
||
| function withHttp (url) { | ||
| if (!url) { |
Member
There was a problem hiding this comment.
I think we don't need this check, do we?
Contributor
Author
There was a problem hiding this comment.
If we don't have the url parameter it'll return an error in line 90 (
I can change url to "let", remove it by applying the function after url parameter validation, like this:
// change const to let
let url = req.query.url;
console.log('/from-url');
if (!url) {
let msg = 'missing parameter: \'url\'';
deliverJson(res, {msg, params: req.params}, 400);
return;
}
let pdfFilePath;
try {
// call the withHttp function before send to generatePdf()
pdfFilePath = await generatePdf(withHttp(url), req.query.media);
Contributor
Author
There was a problem hiding this comment.
@fabriciojs
What do you think? I like this new version of code, we check url parameter once
fabriciojs
approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8 It's not possible to convert using from-url without protocol http(s)
Added function to check if the URL has HTTP protocol and prepend it.