Add Gltf ModelTemplate#207
Merged
fabmax merged 9 commits intokool-engine:mainfrom May 8, 2026
Merged
Conversation
fabmax
reviewed
May 8, 2026
| return ModelGenerator().makeModel(cfg) | ||
| } | ||
|
|
||
| private inner class ModelGenerator { |
Collaborator
There was a problem hiding this comment.
I assume not much else has changed here apart from the Mesh.releaseGeometry flag?
It's a bit hard to see because it's shown as new code due to the move (but moving is fine)
Contributor
Author
There was a problem hiding this comment.
There shouldn't be any other changes, I'll try to create a diff of the moved code with the current main branch to ensure there aren't any changes I have missed.
Contributor
Author
There was a problem hiding this comment.
There were more changes than I remembered. I created a commit which shows a partial diff to the main branch:
dragbone@8a45384
fabmax
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
MeshGltfFileto newModelTemplateModelTemplateNote:
Meshhasn't checked if its geometry has been released until now. The added release checks inMeshwill probably break some cases that "worked" with async rendering but would probably have failed on non-async backends.