Button to write restored snapshot files sparsely #61
Conversation
This commit adds a new radial button (required value) to the snapshot restore window allowing users to enable the sparse restore option. When enabled, the restored snapshot's files are written sparsely, minimizing disk allocations for the written content. This option is disabled by default.
| {RequiredBoolean(this, "Write files atomically", "writeFilesAtomically")} | ||
| </Row> | ||
| <Row> | ||
| {RequiredBoolean(this, "Write files sparsely", "writeFilesSparsely")} |
There was a problem hiding this comment.
I think "sparse files" is more obvious here, so "Write sparse files". Also the second argument should be the name of the JSON field, so "sparse".
See #57 (comment) for testing instructions.
There was a problem hiding this comment.
That makes sense, thanks for the feedback and test instructions. Iterating
There was a problem hiding this comment.
This needs to match JSON tag in restore.FilesystemOutput:
// Sparse when set to true causes the restored files to be sparse.
Sparse bool `json:"sparse"`
There was a problem hiding this comment.
Gotcha, so what does this line do:
req.fsOutput = {
...
writeFilesAtomically: this.state.writeFilesAtomically
+ sparse: this.state.writeFilesSparsely,
}There was a problem hiding this comment.
In hindsight, this is a minor stylistic point, but I agree it's better to rename this variable WriteSparseFiles everywhere (--sparse -> --write-sparse-files etc.) I fear of breaking backwards compatibility, so will leave it as is in restore.FilesystemOutput for now.
There was a problem hiding this comment.
this is a new feature so not really breaking, i think
There was a problem hiding this comment.
Implemented this here: kopia/kopia#2095. I'll follow up with changes to the UI once the above is merged.
* Button to write restored snapshot files sparsely kopia/htmlui#61 by @adowair * Refine appearance of "Create New Repository" form kopia/htmlui#62 by @gitname * Fix a couple typos, adjust some wording, and cleanup some formatting kopia/htmlui#63 by @L1ghtmann * Display task status durations using larger time units kopia/htmlui#64 by @gitname * Display repository description on every page kopia/htmlui#65
This commit renames the sparse restore flag (`kopia snapshot restore` and `kopia restore`) to conform more with the naming precedents in the Kopia code. This is a breaking change. The original motivation can be found here: kopia/htmlui#61 (comment)
This commit renames the sparse restore flag (`kopia snapshot restore` and `kopia restore`) to conform more with the naming precedents in the Kopia code. This is a breaking change. The original motivation can be found here: kopia/htmlui#61 (comment)
2 participants
This commit adds a new radial button (required value) to the snapshot
restore window allowing users to enable the sparse restore option.
When enabled, the restored snapshot's files are written sparsely,
minimizing disk allocations for the written content. This option is
disabled by default.