Use centrally managed AWS Include script#703
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
The AWS include script is part of our larger tooling, but within this repository it is only used to download images from our "staging" ECRs. This commit removes other environments and removes some dead code.
On MacOS 26, running /bin/bash will run version 3.2 of Bash. We need a later version in order to use the centrally-managed aws-include file, so in this commit I've updated the hash-bang line to use "env" - on my machine this loads bash v5.
gsavage
force-pushed
the
use-server-aws-include
branch
from
e11e093 to
c504dcc
Compare
Update the docker-login script to use the aws include from the "Server" repo so that we can manage it centrally and reduce duplication. There is one use-case within CI, and that cannot use the centrally-managed repo, so I've added conditional logic here to detect if we're running in CI.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
jbpros
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several scripts here at Kosli require access to our named AWS accounts; this commit updates the docker-login script to use a copy of the AWS Include script from the "Server" repository, rather than the one stored here. This means that updates to the list of accounts can be handled in one place, and we reduce duplication.
Therefore, this commit also includes the deletion of the AWS Include script from this repository.
The script from the Server repository includes syntax that requires a version of Bash greater than 4, so the hash-bang line here has been updated, too, to use env in order to load the correct version of Bash - this is required on a Mac otherwise we load v3.2