Skip to content

chore: remove Goreleaser warnings#739

Merged
mbevc1 merged 1 commit intomainfrom
20260325_goreleaser
Mar 25, 2026
Merged

chore: remove Goreleaser warnings#739
mbevc1 merged 1 commit intomainfrom
20260325_goreleaser

Conversation

@mbevc1
Copy link
Copy Markdown
Contributor

@mbevc1 mbevc1 commented Mar 25, 2026

  • remove deprecation noise
  • add GHA sensible defaults

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 25, 2026

Claude finished @mbevc1's task in 1m 33s —— View job


Reviewing PR #739

  • Gather context and read changed files
  • Run static analysis checks (go build, go vet, go mod tidy — all pass)
  • Review code changes
  • Post review feedback

Static Analysis

All checks pass — go build ./..., go vet ./..., and go mod tidy produce no issues. This is expected since the PR only touches config files.

Review

.github/workflows/release.yml — Pinning GoReleaser to ~> v2 instead of latest is a good practice. It avoids surprise breakage from a future v3 while still picking up v2 patch/minor releases. The inline # latest comment is slightly misleading (it's not "latest", it's "latest v2.x"), but it's minor.

.goreleaser.yml — The new release and changelog sections make implicit defaults explicit, which suppresses GoReleaser v2 deprecation warnings. All values (prerelease: auto, draft: false, disable: false, changelog.use: git, changelog.sort: asc) match GoReleaser v2 defaults, so this is a no-op change in behavior — purely silencing warnings.

One small note: the comment # github(-native) on use: git is a bit cryptic. It seems to document the alternative option that was not chosen. Consider expanding it slightly (e.g., # alternatives: github, github-native) or removing it to avoid confusion.

Summary

Clean, low-risk PR. The version pinning and explicit config are both sensible maintenance improvements. No bugs, no security concerns, no behavioral changes. LGTM.

@mbevc1 mbevc1 enabled auto-merge (squash) March 25, 2026 11:47
@mbevc1 mbevc1 merged commit 35a4fc4 into main Mar 25, 2026
17 checks passed
@mbevc1 mbevc1 deleted the 20260325_goreleaser branch March 25, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants