Skip to content

Fix daily CLI test#746

Merged
ToreMerkely merged 1 commit intomainfrom
fix-daily-test
Mar 31, 2026
Merged

Fix daily CLI test#746
ToreMerkely merged 1 commit intomainfrom
fix-daily-test

Conversation

@ToreMerkely
Copy link
Copy Markdown
Contributor

No description provided.

@ToreMerkely ToreMerkely enabled auto-merge (squash) March 31, 2026 06:49
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 31, 2026

Claude finished @ToreMerkely's task in 1m 50s —— View job


Review: Fix daily CLI test

  • Gather context and read changed files
  • Run static analysis (go build, go vet — both pass, no Go code changed)
  • Review changes

Summary

LGTM — straightforward and correct fix.

The test.yml reusable workflow defines an input called report_to_kosli (a string, defaulting to 'none'). The daily CLI test workflow was passing report_results: false — a parameter that doesn't exist in test.yml, so it was silently ignored. This PR fixes the parameter name to report_to_kosli: 'none', which matches the expected input.

No concerns — the change is minimal, correct, and consistent with how all other callers of test.yml use this parameter (e.g., main.yml, release.yml).

@ToreMerkely ToreMerkely merged commit f9d4492 into main Mar 31, 2026
24 of 25 checks passed
@ToreMerkely ToreMerkely deleted the fix-daily-test branch March 31, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants