Skip to content

Remove latest_activity from repo list and get commands#770

Merged
jumboduck merged 1 commit intomainfrom
5180-remove-repo-latest-activity
Apr 9, 2026
Merged

Remove latest_activity from repo list and get commands#770
jumboduck merged 1 commit intomainfrom
5180-remove-repo-latest-activity

Conversation

@jumboduck
Copy link
Copy Markdown
Contributor

The field always returns null in production and is being removed
from the API response (kosli-dev/server#5180).

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

The field always returns null in production and is being removed
from the API response (kosli-dev/server#5180).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 9, 2026

Claude finished @jumboduck's task in 1m 34s —— View job


PR Review: Remove latest_activity from repo list and get commands

  • Run static analysis (build, vet, mod tidy)
  • Read changed files and review code
  • Post review feedback

Static Analysis

All checks pass:

  • go build ./... — clean
  • go vet ./... — clean
  • go mod tidy — no drift

Review

Clean, straightforward removal. No issues found.

Correctness: Both getRepo.go and listRepos.go are updated consistently — the field is removed from the table header, row formatting, and the nil-check logic in the list command. No remaining references to latest_activity, LAST_ACTIVITY, or Latest Activity anywhere in the codebase (including tests).

Scope: The listRepos.go change correctly removes the nil-guard that was only needed for latest_activity, simplifying the loop body. The format string arity matches the updated column count in both files.

Tests: Existing test files (getRepo_test.go, listRepos_test.go) don't reference the removed field, so no test updates are needed.

LGTM — this is a clean field removal tied to the server-side change (kosli-dev/server#5180).

@jumboduck jumboduck marked this pull request as ready for review April 9, 2026 13:28
@jumboduck jumboduck enabled auto-merge (squash) April 9, 2026 13:30
@jumboduck jumboduck merged commit efbf9c4 into main Apr 9, 2026
16 checks passed
@jumboduck jumboduck deleted the 5180-remove-repo-latest-activity branch April 9, 2026 13:34
github-actions bot pushed a commit that referenced this pull request Apr 9, 2026
The field always returns null in production and is being removed
from the API response (kosli-dev/server#5180).

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants