-
Notifications
You must be signed in to change notification settings - Fork 6
docs: clarify OpenShift runAsUser must be explicitly set to null #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,16 +70,25 @@ reporterConfig: | |
| # -- the http proxy url | ||
| httpProxy: "" | ||
|
|
||
| # -- the security context for the reporter cronjob | ||
| # Set to null or {} to disable security context entirely (not recommended) | ||
| # For OpenShift, you can omit runAsUser to let OpenShift assign the UID | ||
| # -- the security context for the reporter cronjob. | ||
| # Set to null or {} to disable security context entirely (not recommended). | ||
| # For OpenShift with SCC, explicitly set runAsUser to null to let OpenShift | ||
| # assign the UID from the allowed range. Simply omitting runAsUser from your | ||
| # values override will not work because Helm deep-merges with these defaults. | ||
| # Example OpenShift override: | ||
| # securityContext: | ||
| # allowPrivilegeEscalation: false | ||
| # runAsNonRoot: true | ||
| # runAsUser: null | ||
|
Comment on lines
+73
to
+82
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice improvement. The example block (lines 79–82) is a great addition — it makes the correct override instantly copy-pasteable for OpenShift users. |
||
| securityContext: | ||
| # -- whether to allow privilege escalation | ||
| allowPrivilegeEscalation: false | ||
| # -- whether to run as non root | ||
| runAsNonRoot: true | ||
| # -- the user id to run as | ||
| # Omit this field for OpenShift environments to allow automatic UID assignment | ||
| # -- the user id to run as. | ||
| # For OpenShift environments with SCC, set to null (runAsUser: null) to allow | ||
| # automatic UID assignment. Simply omitting this field will not work due to | ||
| # Helm's deep merge with chart defaults. | ||
| runAsUser: 1000 | ||
|
|
||
| # -- map of plain environment variables to inject into the reporter container. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The
securityContextdescription in this table cell is quite dense now that it includes the full example. This is a limitation ofhelm-docsflattening multi-line comments into a single cell, so there's not much to do here — just flagging for awareness. The source of truth (values.yaml) reads well, which is what matters most.