Makefile: fixed setup_test_to_use_xxx to only clean up the cli containers and not all containers#837
Conversation
ToreMerkely
commented
Apr 29, 2026
ToreMerkely
commented
- fix(make): scope setup_test_to_use_local_image cleanup to the compose stack
- fix(make): scope setup_test_to_use_staging_server_image cleanup to the compose stack
… stack The previous target ran `docker ps -aq | xargs -r docker rm -fv`, which force-removes EVERY container on the host — not just the kosli test stack defined in docker-compose.yml. That's a footgun for anyone running unrelated containers (other projects, dev DBs, sidecar tools) on the same machine. `docker compose down -v` only touches the project's own containers plus its named volumes — exactly what's needed when switching to a locally-built server image. Same approach already used by bin/reset-or-start-server.sh. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…e compose stack Same broad-cleanup footgun as setup_test_to_use_local_image fixed in the previous commit — `docker ps -aq | xargs -r docker rm -fv` force- removes EVERY container on the host. Replaced with `docker compose down -v`, which only touches the project's own compose stack. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @ToreMerkely's task in 1m 38s —— View job PR Review: Scope Makefile cleanup to compose stack
Static AnalysisAll checks pass — ReviewThe change is correct and well-scoped. The old commands ( This also aligns with how No issues found. The change is minimal, safe, and solves a real problem (e.g., accidentally killing unrelated containers during local development). LGTM. |
2 participants
