You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All 8 packages have updated publishing settings including "Require two-factor authentication and disallow tokens (recommended)" as per npm recommandations.
All checks pass — go build ./..., go vet ./..., and go mod tidy report no issues. This PR only touches npm/workflow files, so that's expected.
Review
This PR looks good. The changes are clean and complete:
All 8 .npmrc files removed — eliminates the _authToken=${NPM_TOKEN} lines that would reference a now-deleted secret. No stale auth config left behind.
NPM_TOKEN removed from release.yml — the workflow already has id-token: write permission (line 123), and npm-publish.sh already passes --provenance when running in GitHub Actions. The OIDC auth path is properly wired.
README updated — the old .npmrc documentation is replaced with a clear note about trusted publishing requirements for new packages. The text annotation on the code fence is a nice touch.
No remaining references — grep confirms zero remaining mentions of NPM_TOKEN, _authToken, or .npmrc across the entire codebase.
One minor note
The README line at 114 says:
The package publishing expects the package is configured for Trusted publishing - so if more platforms are added you must configure the new packages accordingly.
This is good documentation. It might be worth also noting where the trusted publisher configuration lives (npm registry settings for each @kosli/* package) so future contributors know where to look — but that's optional polish, not a blocker.
Summary
Clean, well-scoped migration. The .npmrc files and NPM_TOKEN secret are fully removed, the OIDC/provenance path was already in place, and the docs are updated. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPM_TOKENhave been deletedfix: #828