Skip to content

fix: npm trusted publishing#843

Merged
jbrejner merged 3 commits into
mainfrom
828-npm-publishing-should-use-trusted-publishing-for-npm-packages
May 1, 2026
Merged

fix: npm trusted publishing#843
jbrejner merged 3 commits into
mainfrom
828-npm-publishing-should-use-trusted-publishing-for-npm-packages

Conversation

@jbrejner
Copy link
Copy Markdown
Contributor

@jbrejner jbrejner commented May 1, 2026

  • All 8 packages have updated publishing settings including "Require two-factor authentication and disallow tokens (recommended)" as per npm recommandations.
  • the secret NPM_TOKEN have been deleted

fix: #828

@jbrejner jbrejner requested a review from AlexKantor87 May 1, 2026 11:27
@jbrejner jbrejner linked an issue May 1, 2026 that may be closed by this pull request
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 1, 2026

Claude finished @jbrejner's task in 2m 39s —— View job


PR Review: npm trusted publishing

  • Run static analysis (build, vet, mod tidy)
  • Review changed files
  • Post review summary

Static Analysis

All checks pass — go build ./..., go vet ./..., and go mod tidy report no issues. This PR only touches npm/workflow files, so that's expected.

Review

This PR looks good. The changes are clean and complete:

  1. All 8 .npmrc files removed — eliminates the _authToken=${NPM_TOKEN} lines that would reference a now-deleted secret. No stale auth config left behind.

  2. NPM_TOKEN removed from release.yml — the workflow already has id-token: write permission (line 123), and npm-publish.sh already passes --provenance when running in GitHub Actions. The OIDC auth path is properly wired.

  3. README updated — the old .npmrc documentation is replaced with a clear note about trusted publishing requirements for new packages. The text annotation on the code fence is a nice touch.

  4. No remaining references — grep confirms zero remaining mentions of NPM_TOKEN, _authToken, or .npmrc across the entire codebase.

One minor note

The README line at 114 says:

The package publishing expects the package is configured for Trusted publishing - so if more platforms are added you must configure the new packages accordingly.

This is good documentation. It might be worth also noting where the trusted publisher configuration lives (npm registry settings for each @kosli/* package) so future contributors know where to look — but that's optional polish, not a blocker.

Summary

Clean, well-scoped migration. The .npmrc files and NPM_TOKEN secret are fully removed, the OIDC/provenance path was already in place, and the docs are updated. No issues found.

Comment thread npm/README.md Outdated
@mbevc1 mbevc1 changed the title Npm trusted publishing fix: npm trusted publishing May 1, 2026
@jbrejner jbrejner removed the request for review from AlexKantor87 May 1, 2026 11:47
Comment thread npm/README.md Outdated
@jbrejner jbrejner merged commit 804ba44 into main May 1, 2026
36 checks passed
@jbrejner jbrejner deleted the 828-npm-publishing-should-use-trusted-publishing-for-npm-packages branch May 1, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPM publishing should use Trusted publishing for npm packages

3 participants