feat(snapshot s3): add --include-regex / --exclude-regex path filters#882
Merged
Conversation
Path filters on `kosli snapshot s3` previously only supported literal prefix matching, so excluding (e.g.) every PNG in a bucket required enumerating each key. Add regex variants in the same style as the existing `--exclude` / `--exclude-regex` pair on `snapshot ecs`, `snapshot lambda`, `snapshot k8s`, and `snapshot cloudrun`.
Contributor
|
Claude finished @mbevc1's task in 2m 7s —— View job Re-review after latest push
Static AnalysisAll clean — Review SummaryThe author addressed all prior review feedback well:
No issues found. The code is clean and ready to merge. Details:
Nice work addressing the review comments. LGTM. |
gsavage
approved these changes
May 11, 2026
mbevc1
pushed a commit
to kosli-dev/docs
that referenced
this pull request
May 11, 2026
) Updates the `kosli snapshot s3` CLI reference to document the new `--include-regex` and `--exclude-regex` path filters introduced in [kosli-dev/cli#882](kosli-dev/cli#882). - Mention regex variants alongside literal-prefix `--include`/`--exclude` in the long description - Add `--include-regex` and `--exclude-regex` rows to the Flags table - Update existing `--include`/`--exclude` descriptions to note mutual exclusivity with the new regex flags - Add an example using `--exclude-regex '.*\.png$'` Co-authored-by: mintlify[bot] <109931778+mintlify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path filters on
kosli snapshot s3previously only supported literal prefix matching, so excluding (e.g.) every PNG in a bucket required enumerating each key. Add regex variants in the same style as the existing--exclude/--exclude-regexpair onsnapshot ecs,snapshot lambda,snapshot k8s, andsnapshot cloudrun.Also cancel old CI runs on on new push