Update github.com/docker/docker dependency to newer moby modules#883
Update github.com/docker/docker dependency to newer moby modules#883mbevc1 wants to merge 2 commits into
Conversation
Replace direct dependency on `github.com/docker/docker v28.5.2+incompatible`
with the redesigned `github.com/moby/moby/client` and
`github.com/moby/moby/api` modules.
Adapts call sites to the new client API:
- ContainerCreate now takes a single ContainerCreateOptions struct
- ContainerStart/ContainerRemove/ImageTag return a result struct
- ContainerList returns a ContainerListResult wrapping []container.Summary
- Image/Container option types moved from api/types/{image,container}
onto the client package (e.g. client.ImagePullOptions)
|
Claude finished @mbevc1's task in 3m 35s —— View job PR Review: Update Docker dependency to moby modules
Phase 1: Static AnalysisAll three checks pass cleanly:
Phase 2: Code ReviewOverall: This is a clean, well-executed migration from the deprecated One item to verifyAPI version negotiation (see inline comment): The old code explicitly called Minor observations
Phase 3: What's done well
|
Replace direct dependency on
github.com/docker/docker v28.5.2+incompatiblewith the redesignedgithub.com/moby/moby/clientandgithub.com/moby/moby/apimodules.Adapts call sites to the new client API:
ContainerCreatenow takes a singleContainerCreateOptionsstructContainerListreturns aContainerListResultwrapping[]container.Summaryapi/types/{image,container}onto the client package (e.g. client.ImagePullOptions)Move away from deprecated library: moby/moby#52404
Should also resolve security alerts: https://github.com/kosli-dev/cli/security/dependabot
Also minor updates to
README.md