Skip to content

fix: remove problematic quotes from schema#921

Merged
mbevc1 merged 1 commit into
mainfrom
20260529_fix_schema
May 30, 2026
Merged

fix: remove problematic quotes from schema#921
mbevc1 merged 1 commit into
mainfrom
20260529_fix_schema

Conversation

@mbevc1
Copy link
Copy Markdown
Contributor

@mbevc1 mbevc1 commented May 29, 2026

Quotes were incorrectly formatting JSON and not added to schema. Applied and tested locally and it works now.

@mbevc1 mbevc1 added bug Something isn't working attestations labels May 29, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 29, 2026

Claude finished @mbevc1's task in 2m 0s —— View job


PR Review: fix: remove problematic quotes from schema

  • Gather context and read changed files
  • Run static analysis checks
  • Review code changes
  • Post review summary

Static Analysis

All checks pass:

  • go build ./... — clean
  • go vet ./... — clean
  • JSON validation — the modified schema is valid JSON

Review

Change summary: In bin/never_alone/four-eyes-result-schema.json, the params field description changes from:

(default "pr-review")

to:

(default: pr-review)

This is a one-line change to a description string inside a JSON Schema file used by kosli create attestation-type (via bin/never_alone/setup_attestation_type.sh).

Assessment: The change is clean and low-risk — it only affects a human-readable description field, not any structural part of the schema. The resulting JSON is valid. Adding the colon after "default" is a minor readability improvement too.

One note: The original escaped quotes (\"pr-review\") were technically valid JSON, so the root cause of the formatting issue the PR author encountered was likely downstream (e.g., in how the Kosli API or CLI processed the description string, or in shell quoting when the file was passed via --schema). It might be worth noting the specific failure mode in the commit message or PR description for future reference, but this is not a blocker.

Verdict: LGTM — straightforward fix, no concerns. 👍

@mbevc1 mbevc1 enabled auto-merge (squash) May 29, 2026 21:26
@mbevc1 mbevc1 merged commit 722db55 into main May 30, 2026
20 checks passed
@mbevc1 mbevc1 deleted the 20260529_fix_schema branch May 30, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attestations bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants