Skip to content

fix: keep hardcoded visibility for backwards compatibility #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbevc1 merged 2 commits into from
May 31, 2026
+9 −3
Merged

fix: keep hardcoded visibility for backwards compatibility #922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcd9b7a
fix: keep hardcoded visibility for backwards compatibility
mbevc1 May 30, 2026
d8ff8b4
chore: remove unnecessary comment
mbevc1 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cmd/kosli/createFlow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,14 @@ type createFlowOptions struct {
}

type FlowPayload struct {
Name string `json:"name"`
Description string `json:"description"`
Template []string `json:"template,omitempty"`
Name string `json:"name"`
Description string `json:"description"`
// TODO: Visibility is deprecated and ignored by recent Kosli servers, but older
// instances still reject the payload without it. Keep sending
// "private" until the minimum supported server version no longer requires
// this field, then remove the field and the assignment in run().
Visibility string `json:"visibility"`
Comment thread
mbevc1 marked this conversation as resolved.
Comment thread
mbevc1 marked this conversation as resolved.
Template []string `json:"template,omitempty"`
}

func newCreateFlowCmd(out io.Writer) *cobra.Command {
Expand Down Expand Up @@ -95,6 +100,7 @@ func (o *createFlowOptions) run(args []string) error {
var url string
var err error
o.payload.Name = args[0]
o.payload.Visibility = "private"

if o.TemplateFile != "" || o.UseEmptyTemplate {
url, err = neturl.JoinPath(global.Host, "api/v2/flows", global.Org, "template_file")
Expand Down
Loading