Not adding the same time for the turning voltage + Update Compare_Exp…#9
Merged
VMLC-PV merged 1 commit intokostergroup:mainfrom Mar 9, 2026
Merged
Conversation
…_Sim_JV The turning voltage had twice the same time associated with it, this does not work with SIMsalabim, where the ion distribution is set to the steady-state? value when adding the same time/voltage-point twice. Furthermore, the Compare Exp & Sim J-V is adjusted, if the simulated J-V curve does not include any datapoints (no converge for any point) then the returned root-mean-square error is simply np.nan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_Sim_JV
The turning voltage had twice the same time associated with it, this does not work with SIMsalabim, where the ion distribution is set to the steady-state? value when adding the same time/voltage-point twice. Furthermore, the Compare Exp & Sim J-V is adjusted, if the simulated J-V curve does not include any datapoints (no converge for any point) then the returned root-mean-square error is simply np.nan