Skip to content

πŸ“š[Docs]: Improve guidelines in CONTRIBUTING.md#59

Merged
kothariji merged 1 commit intokothariji:masterfrom
KshitijDarekar:Kshitij_Darekar
Mar 15, 2021
Merged

πŸ“š[Docs]: Improve guidelines in CONTRIBUTING.md#59
kothariji merged 1 commit intokothariji:masterfrom
KshitijDarekar:Kshitij_Darekar

Conversation

@KshitijDarekar
Copy link
Copy Markdown
Contributor

@KshitijDarekar KshitijDarekar commented Mar 14, 2021

{minor change in the GitHub command to set the upstream repository, mentioned in the Contributing.md file}

@KshitijDarekar
{οΏ½[Docs]: }
7a68902 
{minor change in the GitHub command to set the upstream repository, mentioned in the Contributing.md file}
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 14, 2021

@KshitijDarekar is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

@KshitijDarekar KshitijDarekar mentioned this pull request Mar 14, 2021
Closed
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/kothariji/syntaxmeets/D1z4ywZV5zwtgZEGd11MKF5SQJLy
βœ… Preview: https://syntaxmeets-git-fork-kshitijdarekar-kshitijdarekar-kothariji.vercel.app

kothariji
kothariji approved these changes Mar 14, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@kothariji kothariji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸš€

@kothariji
Copy link
Copy Markdown
Owner

kothariji commented Mar 14, 2021

LGTM πŸš€

@AyushShri Please review this PR, so we can merge it if everything is fine.

@kothariji kothariji linked an issue Mar 14, 2021 that may be closed by this pull request
Docs: Change the github command to set the upstream in CONTRIBUTING.md #54
Closed
AyushShri
AyushShri approved these changes Mar 14, 2021
View reviewed changes
Copy link
Copy Markdown

@AyushShri AyushShri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @KshitijDarekar for this issue #59 . I have reviewed and approved the changes and Dhruv we can definitely merge the PR @kothariji ! :)
Happy Contributing @KshitijDarekar !

@kothariji kothariji added documentation Improvements or additions to documentation GSSOC21 Level0 Minor Documentation (level 0) labels Mar 15, 2021
@kothariji kothariji merged commit 3d99d7c into kothariji:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kothariji kothariji kothariji approved these changes

+1 more reviewer

@AyushShri AyushShri AyushShri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation GSSOC21 Level0 Minor Documentation (level 0)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Change the github command to set the upstream in CONTRIBUTING.md

3 participants

@KshitijDarekar @kothariji @AyushShri