Skip to content

🚀[Feat]: Add room-id message #60#67

Merged
kothariji merged 3 commits intokothariji:masterfrom
simran2607:share-room-id-msg
Mar 15, 2021
Merged

🚀[Feat]: Add room-id message #60#67
kothariji merged 3 commits intokothariji:masterfrom
simran2607:share-room-id-msg

Conversation

@simran2607
Copy link
Copy Markdown
Contributor

@simran2607 simran2607 commented Mar 15, 2021

Issue solved #60
Upon clicking room-id inside SyntaxRoom, following message will be copied to the clipboard:

Hi there! You have been invited by NAME to join SyntaxMeets.

Click on this link - https://syntaxmeets.vercel.app

and join the room by providing your name and Room-Id: ROOM_ID

where NAME and ROOM_ID are dynamic.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 15, 2021

@simran2607 is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

@simran2607 simran2607 changed the title changed room-id message #60 🚀[Feat]:Add room-id message #60 Mar 15, 2021
@simran2607 simran2607 changed the title 🚀[Feat]:Add room-id message #60 🚀[Feat]: Add room-id message #60 Mar 15, 2021
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 15, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kothariji/syntaxmeets/7GszJcrWYKYqj3azgk7x4Vs9cEJJ
✅ Preview: https://syntaxmeets-git-fork-simran2607-share-room-id-msg-kothariji.vercel.app

@kothariji kothariji linked an issue Mar 15, 2021 that may be closed by this pull request
Share button for room-Id #60
Closed
kothariji
kothariji approved these changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@kothariji kothariji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🚀
Thank you @simran2607 for your contributions 🙌

@kothariji kothariji merged commit cc9881b into kothariji:master Mar 15, 2021
@simran2607
Copy link
Copy Markdown
Contributor Author

simran2607 commented Mar 15, 2021

Great 🚀
Thank you @simran2607 for your contributions 🙌

Thanks a lot for your guidance, hope to contribute more 👍🙌

@kothariji
Copy link
Copy Markdown
Owner

kothariji commented Mar 15, 2021

Great 🚀
Thank you @simran2607 for your contributions 🙌

Thanks a lot for your guidance, hope to contribute more 👍🙌

Sure 🙌

@kothariji kothariji added GSSOC21 Level1 Major Documentation, Minor Code Changes (level 1) fixed labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kothariji kothariji kothariji approved these changes

Assignees

No one assigned

Labels

fixed GSSOC21 Level1 Major Documentation, Minor Code Changes (level 1)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Share button for room-Id

2 participants

@simran2607 @kothariji