Skip to content

[Feat]: Improved chat message UI#82

Merged
kothariji merged 2 commits intokothariji:masterfrom
amaan-ahmad:chatmessage_color
Mar 18, 2021
Merged

[Feat]: Improved chat message UI#82
kothariji merged 2 commits intokothariji:masterfrom
amaan-ahmad:chatmessage_color

Conversation

@amaan-ahmad
Copy link
Copy Markdown
Contributor

As referring to issue #80

I stored the name of the user in local storage whenever they create/join the room.
and then compare it with data.name in ChatMessage.js as needed to do CSS-in-JS styling.

The output looks like this 👇

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 17, 2021

@amaan-ahmad is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

@kothariji
Copy link
Copy Markdown
Owner

Great work @amaan-ahmad 🔥 ,
But can you please resolve PR #78 so that we can review this PR

@amaan-ahmad
Copy link
Copy Markdown
Contributor Author

Thanks @kothariji
also, I have now resolved PR #78 and hopefully didn't create another conflict 😅
Looking forward to getting reviewed on the latest changes as well as this PR.

@kothariji kothariji linked an issue Mar 18, 2021 that may be closed by this pull request
@kothariji
Copy link
Copy Markdown
Owner

Thanks @kothariji
also, I have now resolved PR #78 and hopefully didn't create another conflict 😅
Looking forward to getting reviewed on the latest changes as well as this PR.

Sure we will analyse your PR, and will soon let you know 🙌

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kothariji/syntaxmeets/2qLRs61f1yDRDYtk56jzWh2yutkV
✅ Preview: https://syntaxmeets-git-fork-amaan-ahmad-chatmessagecolor-kothariji.vercel.app

@kothariji
Copy link
Copy Markdown
Owner

Thanks @kothariji
also, I have now resolved PR #78 and hopefully didn't create another conflict 😅
Looking forward to getting reviewed on the latest changes as well as this PR.

@amaan-ahmad can you please pull the updated code from original repo, and again commit the changes, as in this PR previous changes are visible

@amaan-ahmad
Copy link
Copy Markdown
Contributor Author

Ok @kothariji
I have now pulled the latest changes from the original repo and pushed them. no conflicts occurred. kindly review.

Copy link
Copy Markdown
Owner

@kothariji kothariji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🚀
This looks really nice 🔥

Keep Contributing, 🙌

@kothariji kothariji merged commit 6642e24 into kothariji:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS GSSOC21 Level2 Bug fixing, adding small features. (level 2) PR:Under-Review ux-improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Making chatbox messages more readable (UI - enhancement)

2 participants