enable deploy with priority for static deploy

[lvjing2]

fix koupleless/koupleless#205

Summary by CodeRabbit

• Refactor

  • Improved the priority handling of business URLs in batch installations for better performance and organization.

• New Features

  • Added a new constructor and method to the CustomBiz class for better URL management.

• Tests

  • Updated unit tests to reflect the new data structure and logic changes for batch installations.
  • Enhanced test cases to handle complex assertions for business URLs.

[coderabbitai]

Walkthrough

The recent update refactors the getBizUrlsFromLocalFileSystem method across multiple files to return a Map<Integer, List<String>> instead of a List<String>. This change introduces a priority order for handling biz URLs, impacting various classes and tests. Key modifications include updating method signatures, altering logic for processing URLs, and enhancing test cases to accommodate the new data structure.

Changes

File Path	Change Summary
.../BatchInstallHelper.java	Refactored getBizUrlsFromLocalFileSystem to return Map<Integer, List<String>> and updated jar file processing logic.
.../UnifiedOperationServiceImpl.java	Modified batchInstall method to handle Map<Integer, List<String>> and updated install logic.
.../UnifiedOperationServiceImplTests.java	Added pathsInOrder and updated mock behavior for getBizUrlsFromLocalFileSystem.
.../CustomBiz.java	Added new constructor with URL parameter, private field bizUrl, and getBizUrl method.
.../BatchInstallHelperTest.java	Changed bizUrls return type to Map<Integer, List<String>> and updated assertions.

"In the code where changes bloom,
URLs now in ordered loom.
With maps and keys, they find their place,
Priorities set, they run the race.
Tests were changed to match the tune,
A better system, coming soon.
🐇✨"

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1b8c7a0 and 9190c24.

Files selected for processing (5)

• arklet-core/src/main/java/com/alipay/sofa/koupleless/arklet/core/ops/BatchInstallHelper.java (2 hunks)
• arklet-core/src/main/java/com/alipay/sofa/koupleless/arklet/core/ops/UnifiedOperationServiceImpl.java (1 hunks)
• arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/component/UnifiedOperationServiceImplTests.java (2 hunks)
• arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/health/custom/model/CustomBiz.java (2 hunks)
• arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/ops/BatchInstallHelperTest.java (2 hunks)

Additional comments not posted (11)

arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/health/custom/model/CustomBiz.java (2)

39-43: New constructor correctly initializes bizUrl along with bizName and bizVersion.

---

100-103: Getter method for bizUrl is implemented correctly.

arklet-core/src/main/java/com/alipay/sofa/koupleless/arklet/core/ops/BatchInstallHelper.java (3)

19-19: Import of PriorityOrdered is necessary for handling priority in URL processing.

---

48-48: Change in method signature to return a Map supports the new prioritization feature.

---

49-80: The internal logic for collecting and sorting URLs based on priority is implemented correctly.

arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/component/UnifiedOperationServiceImplTests.java (2)

140-143: Mock setup correctly handles the new return type of getBizUrlsFromLocalFileSystem.

---

140-143: Test logic correctly handles the new Map structure of URLs.

arklet-core/src/main/java/com/alipay/sofa/koupleless/arklet/core/ops/UnifiedOperationServiceImpl.java (2)

108-132: Changes to batchInstall method to handle the new Map structure and use a thread pool for asynchronous tasks are implemented correctly.

---

113-132: Handling of installation results using a Map and a boolean flag to track failures is robust and effective.

arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/ops/BatchInstallHelperTest.java (2)

132-138: Test logic correctly handles the new Map structure of URLs using streams for assertions.

---

132-138: Use of streams to handle assertions with the new Map structure is effective and clean.