<feature> 服务模型 #80

gaosaroma · 2024-05-20T14:06:28Z

Summary by CodeRabbit

New Features
- Introduced new error codes for better service management: Service not found and Protocol not registered.
- Added new matchers and adapter mappings for different versions of spring-boot-autoconfigure.
Enhancements
- Improved service component management with new interfaces and methods for registering, unregistering, and retrieving service components.
- Updated BizRuntimeContext to support component registry functionalities.
Bug Fixes
- Fixed artifactId for the spring-boot-starter-logging matcher.
Tests
- Added comprehensive tests for service and reference registration and unregistration functionalities.

…e_cache # Conflicts: # arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/health/custom/model/CustomBiz.java

coderabbitai · 2024-05-20T14:06:39Z

Walkthrough

The updates bring new service component registration and management features to koupleless-common, including classes like AbstractComponent and interfaces such as ComponentRegistry and ServiceState. Error codes were included, dependencies updated, and the project version incremented to 1.3.0-SNAPSHOT. Test cases and mock components were also added to support these new functionalities.

Changes

File Path	Change Summary
`koupleless-common/pom.xml`	Added a new dependency on `org.projectlombok:lombok`.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java`	`BizRuntimeContext` now implements `ComponentRegistry` and adds service component registration methods.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/exception/ErrorCodes.java`	Added error codes `E200001` and `E200002` for service management in `ServiceManager` class.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractComponent.java`	Introduced `AbstractComponent` with properties and a method to set `bizRuntimeContext`.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractReferenceComponent.java`	Defined `AbstractReferenceComponent` extending `AbstractComponent` with a constructor.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractServiceComponent.java`	Introduced `AbstractServiceComponent` extending `AbstractComponent` with `serviceState` field and constructor.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/BeanRegistry.java`	Provided `BeanRegistry` class to manage a registry of beans.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ComponentRegistry.java`	Defined `ComponentRegistry` interface for managing service components.
`koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ServiceState.java`	Introduced `ServiceState` enum representing service states.
`koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/BizRuntimeContextTest.java`	Added test cases for `BizRuntimeContext` functionality.
`koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/model/MockReferenceComponent.java`	Introduced `MockReferenceComponent` class extending `AbstractReferenceComponent` with a builder method.
`koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/model/MockServiceComponent.java`	Defined `MockServiceComponent` extending `AbstractServiceComponent` with a constructor.
`koupleless-ext/koupleless-build-plugin/.../adapter-mapping.yaml`	Added new matchers and adapter mappings for various versions of `spring-boot-autoconfigure`.
`pom.xml`	Updated `<revision>` property from `1.2.1-SNAPSHOT` to `1.3.0-SNAPSHOT`.

In the land of code, where logic blooms,
Dependencies were added, clearing glooms.
Components now register with grace,
Services find their rightful place.
Error codes guide the way,
Ensuring smooth operations every day.
Version bumped, features enhanced,
In the rabbit's realm, code advancements danced. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4ea0570 and f79d8b4.

Files selected for processing (14)

koupleless-common/pom.xml (1 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java (4 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/exception/ErrorCodes.java (1 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractComponent.java (1 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractReferenceComponent.java (1 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractServiceComponent.java (1 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/BeanRegistry.java (1 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ComponentRegistry.java (1 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ServiceState.java (1 hunks)
koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/BizRuntimeContextTest.java (1 hunks)
koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/model/MockReferenceComponent.java (1 hunks)
koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/model/MockServiceComponent.java (1 hunks)
koupleless-ext/koupleless-build-plugin/koupleless-base-build-plugin/src/main/resources/adapter-mapping.yaml (1 hunks)
pom.xml (1 hunks)

Files skipped from review due to trivial changes (2)

koupleless-common/pom.xml
pom.xml

Additional comments not posted (17)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractReferenceComponent.java (1)

23-28: The implementation of AbstractReferenceComponent correctly extends AbstractComponent and passes parameters to the superclass constructor.

koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/model/MockReferenceComponent.java (1)

26-31: The MockReferenceComponent class is well implemented for testing purposes with the @Builder annotation enhancing object creation.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractServiceComponent.java (1)

26-36: The AbstractServiceComponent class is correctly implemented, with proper use of Lombok annotations for the serviceState field to manage its accessibility.

koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/model/MockServiceComponent.java (1)

28-34: The MockServiceComponent class is well implemented for testing purposes, using the @Builder annotation effectively for simplified object creation.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ComponentRegistry.java (1)

25-44: The ComponentRegistry interface is well designed, providing a flexible and clear API for component management with appropriate generic methods.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ServiceState.java (1)

23-48: The ServiceState enum is well implemented, providing robust methods for state management and conversion from strings.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/BeanRegistry.java (1)

28-50: The BeanRegistry class is correctly implemented, providing a thread-safe and efficient way to manage beans with appropriate methods for registration, retrieval, and cleanup.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/exception/ErrorCodes.java (1)

54-62: The new error codes E200001 and E200002 are well defined and appropriately documented, enhancing the error management capabilities of the service.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/AbstractComponent.java (3)

28-37: Properties are well-defined and appropriately encapsulated.

39-47: Constructor correctly initializes all properties.

49-51: Method setBizRuntimeContext is correctly implemented.

koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/BizRuntimeContextTest.java (2)

32-40: Test method testService correctly tests service registration and unregistration.

42-50: Test method testReference correctly tests reference registration and unregistration.

koupleless-ext/koupleless-build-plugin/koupleless-base-build-plugin/src/main/resources/adapter-mapping.yaml (1)

55-78: New adapter mappings for spring-boot-autoconfigure are correctly formatted and cover the specified versions.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java (3)

42-53: New fields in BizRuntimeContext are well-defined and correctly initialized.

164-213: Methods for service and reference management in BizRuntimeContext are correctly implemented and include proper error handling.

Line range hint 40-213: Overall implementation of BizRuntimeContext as ComponentRegistry is consistent and well-structured.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f79d8b4 and befeac6.

Files selected for processing (3)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java (4 hunks)
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ComponentRegistry.java (1 hunks)
koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/BizRuntimeContextTest.java (1 hunks)

Files skipped from review as they are similar to previous changes (3)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java
koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/service/ComponentRegistry.java
koupleless-common/src/test/java/com/alipay/sofa/koupleless/common/BizRuntimeContextTest.java

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between befeac6 and 4f397b3.

Files selected for processing (2)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java (3 hunks)
koupleless-ext/koupleless-build-plugin/koupleless-base-build-plugin/src/main/resources/adapter-mapping.yaml (1 hunks)

Files skipped from review as they are similar to previous changes (2)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java
koupleless-ext/koupleless-build-plugin/koupleless-base-build-plugin/src/main/resources/adapter-mapping.yaml

codecov · 2024-05-21T12:45:40Z

Codecov Report

Attention: Patch coverage is 58.73016% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 79.09%. Comparing base (1b8c7a0) to head (4f397b3).
Report is 50 commits behind head on main.

❗ Current head 4f397b3 differs from pull request most recent head 3a46b22

Please upload reports for the commit 3a46b22 to get more accurate results.

Files	Patch %	Lines
...ipay/sofa/koupleless/common/BizRuntimeContext.java	61.11%	6 Missing and 1 partial ⚠️
...y/sofa/koupleless/common/service/ServiceState.java	45.45%	6 Missing ⚠️
...a/koupleless/common/service/AbstractComponent.java	70.58%	5 Missing ⚠️
...y/sofa/koupleless/common/service/BeanRegistry.java	54.54%	5 Missing ⚠️
...eless/common/service/AbstractServiceComponent.java	60.00%	2 Missing ⚠️
...y/sofa/koupleless/common/exception/ErrorCodes.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main      #80      +/-   ##
============================================
- Coverage     79.92%   79.09%   -0.83%     
  Complexity      156      156              
============================================
  Files            61       65       +4     
  Lines          1654     1732      +78     
  Branches        183      192       +9     
============================================
+ Hits           1322     1370      +48     
- Misses          242      270      +28     
- Partials         90       92       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java

lvjing2

LGTM

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f397b3 and f7f1ed4.

Files selected for processing (2)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java (3 hunks)
pom.xml (1 hunks)

Files skipped from review as they are similar to previous changes (2)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java
pom.xml

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f7f1ed4 and 3a46b22.

Files selected for processing (1)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java (3 hunks)

Files skipped from review as they are similar to previous changes (1)

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java

lvjing2

LGTM

gaosaroma added 5 commits May 17, 2024 15:22

init服务模型缓存

ce4e85f

update 服务缓存模型

7355655

fix 服务缓存模型

d792bc1

format

d47b33f

Merge remote-tracking branch 'koupleless/main' into dev_lipeng_servic…

f79d8b4

…e_cache # Conflicts: # arklet-core/src/test/java/com/alipay/sofa/koupleless/arklet/core/health/custom/model/CustomBiz.java

coderabbitai bot reviewed May 20, 2024

View reviewed changes

gaosaroma added 2 commits May 21, 2024 11:11

先移除ReferenceComponent

4698016

format

befeac6

coderabbitai bot reviewed May 21, 2024

View reviewed changes

gaosaroma added 2 commits May 21, 2024 20:39

revert adapter-mapping

fa50cb2

fix typo

4f397b3

coderabbitai bot reviewed May 21, 2024

View reviewed changes

lvjing2 reviewed May 21, 2024

View reviewed changes

koupleless-common/src/main/java/com/alipay/sofa/koupleless/common/BizRuntimeContext.java Outdated Show resolved Hide resolved

lvjing2 approved these changes May 23, 2024

View reviewed changes

gaosaroma added 2 commits May 23, 2024 16:30

jacoco add exclude ServiceState

f7f1ed4

format

3a46b22

coderabbitai bot reviewed May 23, 2024

View reviewed changes

lvjing2 approved these changes May 24, 2024

View reviewed changes

lvjing2 merged commit cc3ed96 into koupleless:main May 24, 2024

coderabbitai bot mentioned this pull request Sep 15, 2024

update to 1.3.1 #188

Merged

coderabbitai bot mentioned this pull request Sep 29, 2024

auto transform traditional application to ark biz module #193

Merged

coderabbitai bot mentioned this pull request Nov 12, 2024

feat:模块复用基座单例bean时，在模块销毁时不销毁基座bean #207

Open

coderabbitai bot mentioned this pull request Nov 25, 2024

<feat> add versionRange for adaptor; support to customize adapter-mapping; support to install a few adapter #211

Merged

coderabbitai bot mentioned this pull request Dec 16, 2024

Fix adaptor default configs for logback #225

Closed

coderabbitai bot mentioned this pull request Dec 27, 2024

fix: Stop Log4j context after biz uninstall (#255) #234

Closed

coderabbitai bot mentioned this pull request Jan 7, 2025

[issue#255] Close log4j2 loggerContext when the module is uninstalled #208

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

<feature> 服务模型 #80

<feature> 服务模型 #80

Uh oh!

gaosaroma commented May 20, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 20, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented May 21, 2024 •

edited

Loading

Uh oh!

Uh oh!

lvjing2 left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

lvjing2 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

<feature> 服务模型 #80

<feature> 服务模型 #80

Uh oh!

Conversation

gaosaroma commented May 20, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

lvjing2 left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

lvjing2 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaosaroma commented May 20, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 20, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented May 21, 2024 •

edited

Loading