Associate window with GtkApplication. #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a NotebookWindow is created, it is not mapped to the Cadabra GtkApplication. This causes window managers to fail to track windows by the app name, leading to issues such as a generic icon showing instead of the cadabra app icon (for example on GNOME shell) and multiple cadabra windows showing up on the dash bar without being grouped by application. Fixed by this commit by calling `GtkApplication::add_window` in the NotebookWindow constructor.
Owner
|
The main window was already added in this way, but the help window was not. I have fixed that on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a NotebookWindow is created, it is not mapped to the Cadabra GtkApplication. This causes window managers to fail to track windows by the app name, leading to issues such as a generic icon showing instead of the cadabra app icon (for example on GNOME shell) and multiple cadabra windows showing up on the dash bar without being grouped by application. Fixed by this commit by calling
GtkApplication::add_windowin the NotebookWindow constructor.