fix: added support for strings containing \0#23
Merged
kpol merged 1 commit intokpol:masterfrom Jan 19, 2025
OliverVea:master
Merged
fix: added support for strings containing \0#23kpol merged 1 commit intokpol:masterfrom OliverVea:master
\0#23kpol merged 1 commit intokpol:masterfrom
OliverVea:master
Conversation
Previously, `Character.Any.Char` was assigned to a default value of `\0`.
This meant that it cannot be differentiated from `new Character('\0')`.
My suggested change is to make `Character.Char` nullable, and base pattern-matching decisions on the nullability instead.
I have added a test to showcase the lack of support for '\0' before the change.
Owner
|
@OliverVea great idea, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Character.Any.Charwas assigned to a default value of'\0'. This meant that it cannot be differentiated fromnew Character('\0').My suggested change is to make
Character.Charnullable, and base pattern-matching decisions on the nullability instead.I have added a test to showcase the lack of support for
'\0'before the change.