Simplify ImageResolveFunc

[mozesl-nokia]

ImageResolveFunc and ResolveToImageForCLIFunc were overly complicated and unnecessary had RunnerOptions as a receiver.

Removed the context arg, the error from the return value and the receiver.

[netlify]

✅ Deploy Preview for kptdocs ready!

Name	Link
🔨 Latest commit	571beaf
🔍 Latest deploy log	https://app.netlify.com/projects/kptdocs/deploys/69b4368828f7380007e06ea6
😎 Deploy Preview	https://deploy-preview-4431--kptdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

This PR simplifies image resolution by refactoring ImageResolveFunc/ResolveToImageForCLIFunc to remove the context.Context parameter, error return, and unnecessary RunnerOptions receiver, and then updates call sites accordingly.

Changes:

• Refactor ImageResolveFunc to func(image string) string and update ResolveToImageForCLIFunc accordingly.
• Update various runners/commands to call ResolveToImage(...) without context/error handling.
• Adjust tests and small formatting accordingly.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
thirdparty/kyaml/runfn/runfn.go	Update function image resolution call site to new ResolveToImage(image) signature.
thirdparty/cmdconfig/commands/cmdeval/cmdeval.go	Remove ctx plumbing for CLI function config image resolution and update call site(s).
pkg/test/runner/runner.go	Minor formatting (blank line removal).
pkg/lib/runneroptions/runneroptions.go	Core API change: simplify resolver function type and factory; remove context/error/receiver.
internal/fnruntime/runner_test.go	Update test to reflect resolver no longer returns an error.
internal/fnruntime/runner.go	Update runner initialization to use new resolver signature without context/error.
commands/fn/doc/cmdfndoc.go	Update doc command to use new resolver factory and signature; remove use of cobra context.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.