Fix CI failure from renderStatus merge conflict with WASM image update#4435
Merged
liamfallon merged 1 commit intokptdev:mainfrom Mar 18, 2026
Merged
Conversation
CI failure due to renderstatus merge fixed. Env variable to use nodejs as wasm env moved to Makefile from Github workflow Signed-off-by: aravind.est <aravindhan.a@est.tech>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aravindtga
requested review from
efiacor,
kispaljr and
mozesl-nokia
as code owners
dosubot
bot
added
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CI breakage caused by overlapping changes from render status condition updates and the gcr.io → ghcr.io image migration by aligning E2E expectations and making the WASM runtime selection consistent across make-driven test/build runs.
Changes:
- Update the
basicpipeline-wasmexpecteddiff.patchto match newghcr.ioWASM function image references and rendered status output. - Set
KPT_FN_WASM_RUNTIME=nodejsvia theMakefile(defaulted, overridable) rather than only in the GitHub Actions workflow. - Remove the now-redundant
KPT_FN_WASM_RUNTIMEenv override from.github/workflows/go.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/testdata/fn-render/basicpipeline-wasm/.expected/diff.patch | Updates E2E expected diff output for ghcr.io WASM images and rendered status condition content. |
| Makefile | Exports KPT_FN_WASM_RUNTIME default to nodejs for make-invoked builds/tests. |
| .github/workflows/go.yml | Removes CI-only WASM runtime env var now covered by Makefile defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
efiacor
approved these changes
Mar 18, 2026
liamfallon
approved these changes
Mar 18, 2026
ciaranjohnston
pushed a commit
that referenced
this pull request
Apr 1, 2026
CI failure due to renderstatus merge fixed. Env variable to use nodejs as wasm env moved to Makefile from Github workflow Signed-off-by: aravind.est <aravindhan.a@est.tech>
NETIZEN-11
pushed a commit
to NETIZEN-11/kpt
that referenced
this pull request
Apr 1, 2026
CI failure due to renderstatus merge fixed. Env variable to use nodejs as wasm env moved to Makefile from Github workflow Signed-off-by: aravind.est <aravindhan.a@est.tech> Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves CI breakage caused by merging #4418 (render status conditions) alongside #4428 (gcr.io -> ghcr.io image migration).
Changes
diff.patchto reflect the new ghcr.io image references from Replace gcr.io container image references with ghcr.io #4428KPT_FN_WASM_RUNTIME=nodejsenv variable from.github/workflows/go.ymltoMakefileso it applies consistently across all build/test contexts, not just CI