Skip to content

fix: remove porch references from kpt docs (#4288)#4453

Open
NETIZEN-11 wants to merge 6 commits intokptdev:mainfrom
NETIZEN-11:fix/remove-porch-refs-4288
Open

fix: remove porch references from kpt docs (#4288)#4453
NETIZEN-11 wants to merge 6 commits intokptdev:mainfrom
NETIZEN-11:fix/remove-porch-refs-4288

Conversation

@NETIZEN-11
Copy link
Copy Markdown

Fixes #4288

Summary

This PR removes outdated references to "porch" from the kpt documentation and aligns the content with the expected behavior of keeping only a minimal high-level reference.

Changes

  • docs/ROADMAP.md

    • Replaced detailed description ("Porch is the recommended approach") with a concise high-level reference.
    • Redirected users to Nephio documentation for porch-related details.
  • documentation/content/en/faq.md

    • Fixed broken [package orchestration] link that pointed to a non-existent file.
    • Updated link to point to Nephio documentation: https://docs.nephio.org/docs/porch/
    • Removed unused reference definition block.
  • documentation/static/images/package-orchestration.svg

    • Removed unused/orphaned porch-related image asset.

Testing

  • No functional/code changes.
  • Verified documentation builds and links manually.

Notes

All detailed porch-related explanations have been removed as per the issue requirement.
A minimal reference is retained where necessary, directing users to Nephio documentation.

Copilot AI review requested due to automatic review settings March 29, 2026 15:24
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 29, 2026

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 3c6cc0b
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/69dcfaa2a265560008edb9dc
😎 Deploy Preview https://deploy-preview-4453--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. documentation Improvements or additions to documentation go Pull requests that update Go code labels Mar 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@NETIZEN-11 NETIZEN-11 force-pushed the fix/remove-porch-refs-4288 branch 2 times, most recently from b9024f6 to b410cb6 Compare March 29, 2026 15:28
@CsatariGergely
Copy link
Copy Markdown
Contributor

Thanks for your pr. You have lots of changes with are not related to the documentation. Please remove those changes. It looks that this pr was created on top of an other change.

Please fix the DCO issue https://github.com/kptdev/kpt/pull/4453/checks?check_run_id=69074191113

@NETIZEN-11 NETIZEN-11 force-pushed the fix/remove-porch-refs-4288 branch 2 times, most recently from 0662755 to 8beffda Compare April 1, 2026 12:51
Copilot AI review requested due to automatic review settings April 1, 2026 12:56
@NETIZEN-11 NETIZEN-11 force-pushed the fix/remove-porch-refs-4288 branch from 8beffda to d83bca5 Compare April 1, 2026 12:56
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 1, 2026
@NETIZEN-11
Copy link
Copy Markdown
Author

Thanks for the feedback!

I have addressed the issues:

  • Removed unrelated changes and kept only documentation updates
  • Rebased the PR on the latest main branch
  • Fixed the DCO issue by signing the commits

Please review again. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

NETIZEN-11 and others added 5 commits April 1, 2026 20:48
…nctions

- Upgrade sigs.k8s.io/kustomize/api from v0.20.1 to v0.21.0
- Upgrade sigs.k8s.io/kustomize/kyaml from v0.20.1 to v0.21.0
- Upgrade k8s.io/api from v0.34.1 to v0.35.0
- Upgrade k8s.io/apimachinery from v0.34.1 to v0.35.0
- Upgrade k8s.io/kubectl from v0.34.1 to v0.35.0
- Upgrade github.com/kptdev/krm-functions-catalog/functions/go/apply-setters from v0.2.2 to v0.2.4
- Update catalog function registry to reference new apply-setters version
- Run go mod tidy to resolve transitive dependencies

Resolves GitHub Issue kptdev#4406

All catalog functions remain compatible with new APIs - zero breaking changes encountered.
Zero compilation errors and zero failing tests across repository.

Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
…n, and CRLF

- Update testdata Kptfiles to use apply-setters:v0.2.4 (was v0.2.0)
  which is not registered in the functions map, causing TestRender failures
- Fix validateFnConfigPathSyntax to use path.IsAbs (forward-slash) instead
  of filepath.IsAbs so absolute path detection works correctly on all platforms
- Normalize CRLF to LF in pkg_context_test.go when reading expected output
  files to fix TestPkgContextGenerator on Windows
- Remove unused absPath helper and os import from executor_test.go

Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
- Remove duplicate entries for apply-setters (v0.2.2) and krm-functions-sdk (v1.0.2)
- Bump k8s.io/apiextensions-apiserver from v0.34.1 to v0.35.0 to align all k8s deps
- Remove gogo/protobuf indirect dep (no longer needed)
- Run go mod tidy to validate

Addresses reviewer feedback on PR kptdev#4432

Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
…ility

The PR bumps apply-setters to v0.2.4 in go.mod. Adding v0.2.4 to the
functions registry is required so Kptfiles referencing the new version
work with the built-in runner. v0.2.0 is kept for backward compatibility
with existing Kptfiles that already reference that version.

Also revert testdata Kptfiles back to v0.2.0 since both versions are
now supported by the functions map.

Addresses reviewer question on PR kptdev#4432

Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
@NETIZEN-11
Copy link
Copy Markdown
Author

Hi @CsatariGergely,

Thanks for the feedback.

I’ve cleaned up the PR and removed unrelated changes. It is now based correctly on the latest main branch.

Also, the DCO issue has been fixed and all checks are passing.

Could you please take another look?

Thanks!

Comment thread docs/ROADMAP.md Outdated
Comment thread documentation/content/en/faq.md Outdated
@NETIZEN-11 NETIZEN-11 force-pushed the fix/remove-porch-refs-4288 branch from d83bca5 to e632e31 Compare April 13, 2026 13:55
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 13, 2026
Copilot AI review requested due to automatic review settings April 13, 2026 13:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@NETIZEN-11 NETIZEN-11 force-pushed the fix/remove-porch-refs-4288 branch 2 times, most recently from e632e31 to c964905 Compare April 13, 2026 14:03
Copilot AI review requested due to automatic review settings April 13, 2026 14:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@NETIZEN-11 NETIZEN-11 force-pushed the fix/remove-porch-refs-4288 branch 2 times, most recently from c964905 to fb3e78f Compare April 13, 2026 14:09
- Replace detailed porch description in ROADMAP.md with a single high-level reference pointing to Nephio documentation
- Fix broken link in faq.md that pointed to non-existent design doc docs/design-docs/07-package-orchestration.md; now points to Nephio
- Remove unused [package orchestration] reference definition from faq.md
- Delete orphaned package-orchestration.svg image asset

Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
Copilot AI review requested due to automatic review settings April 13, 2026 14:15
@NETIZEN-11 NETIZEN-11 force-pushed the fix/remove-porch-refs-4288 branch from fb3e78f to 3c6cc0b Compare April 13, 2026 14:15
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@liamfallon
Copy link
Copy Markdown
Contributor

There are non-documentation changes in this PR.

Comment thread internal/builtins/pkg_context_test.go
Comment thread internal/kptops/functions.go
Comment thread internal/util/render/executor_test.go
Comment thread pkg/api/kptfile/v1/validation.go
Comment thread go.mod
Comment thread go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation go Pull requests that update Go code size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: documentation still refers to porch in a number of places

5 participants