fix: remove porch references from kpt docs (#4288)#4453
Open
NETIZEN-11 wants to merge 6 commits intokptdev:mainfrom
Open
fix: remove porch references from kpt docs (#4288)#4453NETIZEN-11 wants to merge 6 commits intokptdev:mainfrom
NETIZEN-11 wants to merge 6 commits intokptdev:mainfrom
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
b9024f6 to
b410cb6
Compare
Contributor
|
Thanks for your pr. You have lots of changes with are not related to the documentation. Please remove those changes. It looks that this pr was created on top of an other change. Please fix the DCO issue https://github.com/kptdev/kpt/pull/4453/checks?check_run_id=69074191113 |
0662755 to
8beffda
Compare
8beffda to
d83bca5
Compare
Author
|
Thanks for the feedback! I have addressed the issues:
Please review again. Thanks! |
…nctions - Upgrade sigs.k8s.io/kustomize/api from v0.20.1 to v0.21.0 - Upgrade sigs.k8s.io/kustomize/kyaml from v0.20.1 to v0.21.0 - Upgrade k8s.io/api from v0.34.1 to v0.35.0 - Upgrade k8s.io/apimachinery from v0.34.1 to v0.35.0 - Upgrade k8s.io/kubectl from v0.34.1 to v0.35.0 - Upgrade github.com/kptdev/krm-functions-catalog/functions/go/apply-setters from v0.2.2 to v0.2.4 - Update catalog function registry to reference new apply-setters version - Run go mod tidy to resolve transitive dependencies Resolves GitHub Issue kptdev#4406 All catalog functions remain compatible with new APIs - zero breaking changes encountered. Zero compilation errors and zero failing tests across repository. Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
…n, and CRLF - Update testdata Kptfiles to use apply-setters:v0.2.4 (was v0.2.0) which is not registered in the functions map, causing TestRender failures - Fix validateFnConfigPathSyntax to use path.IsAbs (forward-slash) instead of filepath.IsAbs so absolute path detection works correctly on all platforms - Normalize CRLF to LF in pkg_context_test.go when reading expected output files to fix TestPkgContextGenerator on Windows - Remove unused absPath helper and os import from executor_test.go Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
- Remove duplicate entries for apply-setters (v0.2.2) and krm-functions-sdk (v1.0.2) - Bump k8s.io/apiextensions-apiserver from v0.34.1 to v0.35.0 to align all k8s deps - Remove gogo/protobuf indirect dep (no longer needed) - Run go mod tidy to validate Addresses reviewer feedback on PR kptdev#4432 Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
…ility The PR bumps apply-setters to v0.2.4 in go.mod. Adding v0.2.4 to the functions registry is required so Kptfiles referencing the new version work with the built-in runner. v0.2.0 is kept for backward compatibility with existing Kptfiles that already reference that version. Also revert testdata Kptfiles back to v0.2.0 since both versions are now supported by the functions map. Addresses reviewer question on PR kptdev#4432 Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
Author
|
Hi @CsatariGergely, Thanks for the feedback. I’ve cleaned up the PR and removed unrelated changes. It is now based correctly on the latest main branch. Also, the DCO issue has been fixed and all checks are passing. Could you please take another look? Thanks! |
efiacor
reviewed
Apr 13, 2026
d83bca5 to
e632e31
Compare
e632e31 to
c964905
Compare
c964905 to
fb3e78f
Compare
- Replace detailed porch description in ROADMAP.md with a single high-level reference pointing to Nephio documentation - Fix broken link in faq.md that pointed to non-existent design doc docs/design-docs/07-package-orchestration.md; now points to Nephio - Remove unused [package orchestration] reference definition from faq.md - Delete orphaned package-orchestration.svg image asset Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
fb3e78f to
3c6cc0b
Compare
Contributor
|
There are non-documentation changes in this PR. |
CsatariGergely
requested changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4288
Summary
This PR removes outdated references to "porch" from the kpt documentation and aligns the content with the expected behavior of keeping only a minimal high-level reference.
Changes
docs/ROADMAP.md
documentation/content/en/faq.md
[package orchestration]link that pointed to a non-existent file.documentation/static/images/package-orchestration.svg
Testing
Notes
All detailed porch-related explanations have been removed as per the issue requirement.
A minimal reference is retained where necessary, directing users to Nephio documentation.