Skip to content

Remove internal/kptops dead code#4481

Merged
efiacor merged 2 commits intokptdev:mainfrom
Nordix:move_kpt_ops
Apr 17, 2026
Merged

Remove internal/kptops dead code#4481
efiacor merged 2 commits intokptdev:mainfrom
Nordix:move_kpt_ops

Conversation

@efiacor
Copy link
Copy Markdown
Contributor

@efiacor efiacor commented Apr 14, 2026

Removal of dead code after move from porch to kpt (internal/kptops)

Fixes #4375

Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Copilot AI review requested due to automatic review settings April 14, 2026 09:03
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 102f399
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/69de05232f25170008ad17c4
😎 Deploy Preview https://deploy-preview-4481--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 14, 2026
@efiacor efiacor self-assigned this Apr 14, 2026
@dosubot dosubot Bot added cleanup go Pull requests that update Go code labels Apr 14, 2026
@efiacor efiacor requested a review from CsatariGergely April 14, 2026 09:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the legacy internal/kptops translators/amendments and related tests/testdata after the move from porch to kpt, keeping pkg/lib/kptops tests working with an in-process runtime.

Changes:

  • Deleted the internal/kptops package and its associated testdata.
  • Removed the pkg/lib/kptops/eval.go simple runtime and its unit test.
  • Introduced a new test-only in-process FunctionRuntime in pkg/lib/kptops/helpers_test.go and trimmed render_test.go accordingly.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/lib/kptops/render_test.go Removes now-obsolete render test; retains printer logging tests with reduced imports.
pkg/lib/kptops/helpers_test.go Adds test-only in-process function runtime + simplified set-labels/set-namespace implementations.
pkg/lib/kptops/eval_test.go Deletes tests that depended on internal/kptops runtime behavior/testdata.
pkg/lib/kptops/eval.go Deletes simple runtime that depended on internal/kptops processors.
internal/kptops/testdata/render-with-inline-config/simple-bucket/bucket.yaml Removes obsolete render test fixture.
internal/kptops/testdata/render-with-inline-config/simple-bucket/Kptfile Removes obsolete render test fixture.
internal/kptops/testdata/render-with-inline-config/expected.txt Removes obsolete render expected output.
internal/kptops/testdata/render-with-function-config/simple-bucket/setters.yaml Removes obsolete render test fixture.
internal/kptops/testdata/render-with-function-config/simple-bucket/bucket.yaml Removes obsolete render test fixture.
internal/kptops/testdata/render-with-function-config/simple-bucket/Kptfile Removes obsolete render test fixture.
internal/kptops/testdata/render-with-function-config/expected.txt Removes obsolete render expected output.
internal/kptops/testdata/bucket/bucket.yaml Removes obsolete fixture used by removed eval test.
internal/kptops/set-namespace.go Deletes dead test-focused function implementation.
internal/kptops/set-labels.go Deletes dead test-focused function implementation.
internal/kptops/functions.go Deletes dead image->processor registry.
internal/kptops/doc.go Deletes package docs for removed internal package.
internal/kptops/apply-setters.go Deletes dead apply-setters wrapper implementation.
go.mod Drops the apply-setters Go module dependency.
go.sum Removes corresponding go.sum entries for the dropped dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/lib/kptops/render_test.go
Comment thread go.mod
Comment thread pkg/lib/kptops/helpers_test.go Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 14, 2026 09:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the now-obsolete internal/kptops implementation and its associated tests/testdata after the move away from porch, keeping pkg/lib/kptops tests self-contained.

Changes:

  • Deleted the internal/kptops package (processors + registry) and all its testdata fixtures.
  • Removed the pkg/lib/kptops/eval.go wrapper runtime and its unit test.
  • Refactored pkg/lib/kptops tests by removing the old render golden tests and adding a lightweight in-process function runtime for remaining render-related tests.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/lib/kptops/render_test.go Removes render golden tests tied to deleted internal/kptops testdata; keeps printer/logging tests.
pkg/lib/kptops/helpers_test.go Adds a test-only in-process FunctionRuntime for render pipeline tests.
pkg/lib/kptops/eval_test.go Deletes eval tests that depended on internal/kptops.
pkg/lib/kptops/eval.go Deletes runtime implementation that depended on internal/kptops.
internal/kptops/testdata/** Removes render/eval fixtures for the deleted package.
internal/kptops/*.go Removes dead processors (apply-setters, set-labels, set-namespace) and registry/doc.
go.mod Drops unused krm-functions-catalog/functions/go/apply-setters module dependency.
go.sum Removes corresponding checksum entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/lib/kptops/helpers_test.go
@dosubot dosubot Bot added the lgtm label Apr 14, 2026
@efiacor efiacor merged commit f3f5ffe into kptdev:main Apr 17, 2026
19 checks passed
@efiacor efiacor deleted the move_kpt_ops branch April 17, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/porch cleanup go Pull requests that update Go code lgtm size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move translators and amendments to KRM functions from kpt into the krm-functions-catalog repo

5 participants