Skip to content

Conversation

@yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Oct 6, 2022

This PR does 3 jobs

  • It adds Results methods.
  • It allow Context to control the flow.
  • It split results from previous context

Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes! Just some nits

@yuwenma yuwenma force-pushed the context branch 5 times, most recently from 8831621 to a054588 Compare October 7, 2022 05:21
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuwenma yuwenma force-pushed the context branch 3 times, most recently from d75d35b to 1a3ac7e Compare October 7, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants