Independent Subpackage Clone and Upgrade: v1alpha1 server implementation#1009
Open
liamfallon wants to merge 35 commits into
Open
Independent Subpackage Clone and Upgrade: v1alpha1 server implementation#1009liamfallon wants to merge 35 commits into
liamfallon wants to merge 35 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for cloning and upgrading independent subpackages by introducing subpackage-dir validation, applying subpackage tasks pre-mutation, and updating upgrade behavior to operate on subpackage-scoped resources.
Changes:
- Add
SubpackageDirvalidation helper (IsValidSubpackageDir) and enforce it during PR mutations. - Apply a dedicated “subpackage task” flow that clones/upgrades subpackage resources into a parent package’s resources.
- Extend upgrade logic to scope local resources to a subpackage when
SubpackageDiris provided, plus substantial new tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| pkg/task/upgrade.go | Scopes local resources to a subpackage before performing upgrade. |
| pkg/task/generictaskhandler.go | Validates subpackage dir, applies subpackage task, and implements resource insert/upgrade helpers. |
| api/porch/v1alpha1/util.go | Adds IsValidSubpackageDir for SubpackageDir validation. |
| pkg/task/generictaskhandler_test.go | Adds test coverage for subpackage clone/upgrade task behavior and edge cases. |
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
8d8922a to
e8d80bc
Compare
Signed-off-by: liamfallon <liam.fallon@est.tech>
13 tasks
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent Subpackage Clone and Upgrade: v1alpha1 server implementation
Description
Related Issue(s)
Type of Change
Checklist
Additional Notes (Optional)
AI Disclosure
I have used Amazon Q to generate utility funcitons in teh code and to generate most of the tests.