FunctionConfig CRD and Reconciler#475
Conversation
✅ Deploy Preview for porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for the PR, excellent work, as always. |
8735664 to
8986492
Compare
1478faa to
ebd73e9
Compare
Co-authored-by: dgyorgy-nokia <daniel.gyorgy@nokia.com>
ebd73e9 to
18f99d5
Compare
|
Related Documentation 8 document(s) may need updating based on files changed in this PR: Porch _index
|
| @@ -258,7 +237,7 @@ func (pcm *podCacheManager) FunctionInfo(image string) *functionInfo { | |||
| } | |||
|
|
|||
| func (pcm *podCacheManager) retrieveFunctionPods(ctx context.Context) error { | |||
There was a problem hiding this comment.
Should this one clean up all pods that are not in the functionconfigstore anymore?
There was a problem hiding this comment.
We do still allow functions that don't have a config, they just always run with the default config in a pod
…dd dockerhub mirror support to postgres image, retry db connection inline in repository controller too, fix lint
liamfallon
left a comment
There was a problem hiding this comment.
Thanks for this, its a great improvement.
|
@mozesl-nokia Could you do a rebase on this? |
|
efiacor
left a comment
There was a problem hiding this comment.
Need to create a few new issues to track the docs and other follow up items. Otherwise, all good




Title
FunctionConfig CRD and Reconciler
Description
Related Issue(s)
Type of Change
Checklist
Additional Notes (Optional)