Removed old subpackage fragments#968
Merged
Merged
Conversation
Signed-off-by: liamfallon <liam.fallon@est.tech>
✅ Deploy Preview for porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the previously non-functional “subpackage” placeholders from Porch’s package init flow and its v1alpha2 API surface, reducing confusion ahead of upcoming real subpackage upgrade support.
Changes:
- Removed
subpackagefrom init task/spec handling and from v1alpha2 API/CRD + CLI API reference docs. - Kept v1alpha1
subpackagefor backward compatibility but marked it deprecated, and updated v1alpha1↔porch conversions accordingly. - Updated generated schemas/conversion code and removed the now-obsolete subpackage init test.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/task/init.go | Removes init-time subpackage directory handling; always initializes at /. |
| pkg/engine/engine.go | Stops setting an explicit empty Subpackage on init task creation. |
| docs/content/en/docs/7_cli_api/api-ref.md | Removes subpackage from the published API reference table. |
| controllers/packagerevisions/pkg/controllers/packagerevision/source.go | Removes v1alpha2 init subpackage path handling; init always at /. |
| controllers/packagerevisions/pkg/controllers/packagerevision/source_test.go | Drops the subpackage init test that no longer applies. |
| controllers/config/crd/bases/config.porch.kpt.dev_packagevariants.yaml | Updates CRD description text for stderr (removes stale placeholder wording). |
| api/porch/v1alpha2/source_types.go | Removes Subpackage from PackageInitSpec. |
| api/porch/v1alpha2/porch.kpt.dev_packagerevisions.yaml | Removes subpackage schema from v1alpha2 PackageRevision source init spec. |
| api/porch/v1alpha1/zz_generated.conversion.go | Updates conversions to drop subpackage when converting into porch types; adjusts some list/pointer conversions. |
| api/porch/v1alpha1/types.go | Deprecates (but retains) v1alpha1 Subpackage field and removes other stale commented placeholders. |
| api/porch/v1alpha1/conversion.go | Adds a manual conversion shim for PackageInitTaskSpec to handle the removed peer field. |
| api/porch/types.go | Removes Subpackage from porch PackageInitTaskSpec and trims placeholder comments in clone spec. |
| api/generated/openapi/zz_generated.openapi.go | Updates generated OpenAPI descriptions to reflect deprecation/removals. |
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
efiacor
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed old subpackage fragments
Description
Related Issue(s)
Type of Change
Checklist
AI Disclosure
[ ] I have used AI in the creation of this PR.