Skip to content

fix: false positive cycle detection for shared struct references #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yanhu007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: false positive cycle detection for shared struct references #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion formatter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,17 @@ func (p *printer) printValue(v reflect.Value, showType, quote bool) {
writeByte(p, '}')
case reflect.Struct:
t := v.Type()
var vis visit
var tracked bool
if v.CanAddr() {
addr := v.UnsafeAddr()
vis := visit{addr, t}
vis = visit{addr, t}
if vd, ok := p.visited[vis]; ok && vd < p.depth {
p.fmtString(t.String()+"{(CYCLIC REFERENCE)}", false)
break // don't print v again
}
p.visited[vis] = p.depth
tracked = true
}

if showType {
Expand Down Expand Up @@ -218,6 +221,11 @@ func (p *printer) printValue(v reflect.Value, showType, quote bool) {
}
}
writeByte(p, '}')
// Remove visit tracking after printing so that shared (non-cyclic)
// references from sibling fields are not falsely detected as cycles.
if tracked {
delete(p.visited, vis)
}
case reflect.Interface:
switch e := v.Elem(); {
case e.Kind() == reflect.Invalid:
Expand Down