Setup workflow and update dependencies #12
Merged
Conversation
Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.9 to 1.1.14. - [Release notes](https://github.com/creack/pty/releases) - [Commits](creack/pty@v1.1.9...v1.1.14) --- updated-dependencies: - dependency-name: github.com/creack/pty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kr
reviewed
Aug 8, 2021
Owner
kr
left a comment
kr
left a comment
There was a problem hiding this comment.
Thanks! This looks pretty good to me. I would just request we do the readme change in a separate PR so it doesn't hold up the dependency stuff.
| @@ -0,0 +1,7 @@ | |||
| This is a Go package for manipulating paragraphs of text. | |||
Owner
There was a problem hiding this comment.
I prefer to do one complete thing at a time in each PR. Renaming & updating the readme seems like a separate thing from updating dependencies to me. What do you think?
kr
approved these changes
Aug 8, 2021
Owner
|
Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same that what was add for pretty
The go.sum was missing, I generated it.
I added badged and fix a golint warning