Fix cache key collision #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realFlowControl
force-pushed
the
florian/fix-cache-key
branch
from
61b9a7d to
a62b0c6
Compare
realFlowControl
force-pushed
the
florian/fix-cache-key
branch
from
a62b0c6 to
29e27ca
Compare
realFlowControl
force-pushed
the
florian/fix-cache-key
branch
from
29e27ca to
f15ca55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the cache key collision described in #309 in
php_parallel_cache_create(), by usingzend_function->op_array.function_nameas the main cache key instead ofzend_function->op_array.opcodeson PHP >= 8.4, as PHP 8.4 introduced "real" names for closures in php/php-src#13550.Older PHP versions have just
{closure}as afunction_name.Fixes #309