Fix array literal copying into threads #364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that shared array literals in the parallel cache are correctly separated (copied) when modified within a thread. By setting the initial refcount of shared persistent arrays (literals) to 2 and clearing the IS_TYPE_REFCOUNTED flag on the corresponding zvals, we force the PHP VM to treat them as shared/immutable for modification purposes (triggering COW), while preventing the VM from attempting non-atomic refcount increments and decrements that would lead to heap corruption and crashes. For private persistent arrays (e.g., closure static variables), we use standard refcounting (initial refcount 1) and enable proper destruction when the refcount drops to 0. This avoids memory leaks for non-recursive cases. The dtor logic in src/copy.c is reverted to expect a refcount of 0 for destruction, which aligns with standard refcounting behavior. Fixes the corruption reported in tests/functional/008.phpt, avoids the race conditions seen in tests/base/063.phpt, and addresses memory leaks in standard closure usage.
realFlowControl
force-pushed
the
florian/refcount
branch
3 times, most recently
from
0d36410 to
e4003af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.