Implemented transformation of delimited value lists#80
Merged
krasa merged 2 commits intoJul 20, 2019
Conversation
krasa
requested changes
Jun 28, 2019
- Use already existing preview editor; also refactored existing usages to remove code duplication - Removed type-prefixes from field names - Added handling to process large inputs in the CommonPool instead of the UI-Thread
Contributor
Author
|
Hi, sorry for the late reply. Haven't got much time in the last couple weeks. |
krasa
added a commit
that referenced
this pull request
Jul 20, 2019
Owner
|
Thanks! Is it just me, or it the async stuff totally unreadable? :) I simplified it, check it out. |
krasa
added a commit
that referenced
this pull request
Jul 20, 2019
krasa
added a commit
that referenced
this pull request
Jul 20, 2019
krasa
added a commit
that referenced
this pull request
Jul 20, 2019
krasa
added a commit
that referenced
this pull request
Jul 20, 2019
krasa
added a commit
that referenced
this pull request
Jul 20, 2019
krasa
added a commit
that referenced
this pull request
Jul 20, 2019
Owner
|
@pmenke-de if it should transform to/from CSV, then it need to be way smarter, for CSV containing: https://www.mkyong.com/java/how-to-read-and-parse-csv-file-in-java/ It also does not handle the original requirement: Maybe it would be better to use some parser library, and choose between that and the current processing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #32
Basic implementation. Requests for changes welcome ;-)