Send back target path for easier using navigo#101
Closed
martonx wants to merge 1 commit intokrasimir:masterfrom
Closed
Send back target path for easier using navigo#101martonx wants to merge 1 commit intokrasimir:masterfrom
martonx wants to merge 1 commit intokrasimir:masterfrom
Conversation
When we catch a navigate event, and we want to do ajax call based on the catched url, and we use just some general route like /user/:action/:id in our rooter, then we need to know what was the originally catched url, without rebuild the original url from response parameters, query strings or without any hacky other solutions). I know this is not the most elegant way, but it doesn't break anything and better then nothing. In v5 navigo should send back an object with { params, query, targetPath } instead of 3 arguments.
krasimir
pushed a commit
that referenced
this pull request
Mar 31, 2017
Owner
|
The router already have describe('when we have a complex route matching', function () {
it('should access easily the matched URL', function () {
var handler = sinon.spy();
router = new Navigo();
router.on('/user/:action/:id', handler);
router.navigate('/user/answer/42').resolve();
expect(handler)
.to.be.calledOnce
.and.be.calledWith({
action: 'answer',
id: '42'
}, '');
expect(router.lastRouteResolved()).to.deep.equal({
url: '/user/answer/42',
query: ''
});
});
});Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we catch a navigate event, and we want to do ajax call based on the catched url, and we use just some general route like /user/:action/:id in our rooter, then we need to know what was the originally catched url, without rebuild the original url from response parameters, query strings or without any hacky other solutions). I know this is not the most elegant way, but it doesn't break anything and better then nothing. In v5 navigo should send back an object with { params, query, targetPath } instead of 3 arguments.