Press Align 2D-Helmholtz code and introduce 1D-SauterSchwab#156
Closed
PioterAdam wants to merge 1 commit intokrcools:masterfrom
Closed
Press Align 2D-Helmholtz code and introduce 1D-SauterSchwab#156PioterAdam wants to merge 1 commit intokrcools:masterfrom
PioterAdam wants to merge 1 commit intokrcools:masterfrom
Conversation
First step in refactoring Helmholtz2D matching the structure of Helmholtz3D code: For now limited to providing a module based interface similar to BEAST.Helmholtz3D TODO: - Match operator types to Helmholtz3D case (i.e., SingleLayer -> HH2DSingleLayerFDBIO etc) - Provide alpha (and beta) pre-factor for operators - Use gamma instead of wavenumber WARNING: Unlike 3D case, we have different kernels for gamma = 0 and gamma = <realnumber> - Excitations need to be adapted - Evaluation of potentials is entirely missing Use Ma-Rokhlin-Wandzura and Sauter-Schwab for 2D Integral Operators Sauter and Schwab describe in Example 5.2.3 a technique to remove the singularity from a 2D-Kernel (as a motivation for the 3D surface integral equation technique). However, due to the logarithmic singularity, the higher-order derivatives still contain a singularity. We therefore combine there technique with the Ma-Rokhlin-Wandzura quadrature. Similar ideas have been presented in the Master thesis "2D Electromagnetic field MoM calculations using well-conditioned higher order polynomials" by Denturck under the supervision of Bogaert.
Owner
|
This looks great. Is there any way to avoid the seemingly identical duplications in |
Author
|
Thanks, at first I wanted to reuse the code as much as possible, but then I noticed some problems ... we can discuss it with Simon |
Contributor
|
I have add a 1D version of permute_vertices in CompScienceMeshes (See krcools/CompScienceMeshes.jl#49) I think once this is merged we are able to reuse all of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step in refactoring Helmholtz2D matching the structure of Helmholtz3D code: For now limited to providing a module based interface similar to BEAST.Helmholtz3D
TODO:
Use Ma-Rokhlin-Wandzura and Sauter-Schwab for 2D Integral Operators
Sauter and Schwab describe in Example 5.2.3 a technique to remove the singularity from a 2D-Kernel (as a motivation for the 3D surface integral equation technique).
However, due to the logarithmic singularity, the higher-order derivatives still contain a singularity. We therefore combine there technique with the Ma-Rokhlin-Wandzura quadrature.
Similar ideas have been presented in the Master thesis "2D Electromagnetic field MoM calculations using well-conditioned higher order polynomials" by Denturck under the supervision of Bogaert.