Add all Dunavant quadrature rules for the triangle#43
Merged
krcools merged 3 commits intokrcools:masterfrom Sep 9, 2024
Merged
Add all Dunavant quadrature rules for the triangle#43krcools merged 3 commits intokrcools:masterfrom
krcools merged 3 commits intokrcools:masterfrom
Conversation
Currently, the first 7 rules of the triangle quadrature are Dunavant's rules. The higher order rules stem from somewhere else (TODO: Add reference when figured out) In addition to the existing mixed rule, we added Dunavant until order 20. The default is still the mixed rule. By wrapping the order in the type TriangleQuadDunavant, the user can select the Dunavant rule. TODO: There are more and better rules out there for integrating on a triangle (some Dunavant rules have negative weights) See, for example, the QuadPy-Package. Probably, we want a similar package for Julia in the future.
Owner
|
Thank you. Just changed the name of one struct and used TestItems.jl for the newly added test. Shall I merge? |
Owner
|
Using SVector instead of Array to store the weights and nodes seems to cause type instability... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the first 7 rules of the triangle quadrature are Dunavant's rules. The higher order rules stem from somewhere else (TODO: Add reference when figured out)
In addition to the existing mixed rule, we added Dunavant until order 20.
The default is still the mixed rule. By wrapping the order in the type TriangleQuadDunavant, the user can select the Dunavant rule.
TODO: There are more and better rules out there for integrating on a triangle (some Dunavant rules have negative weights) See, for example, the QuadPy-Package.
Probably, we want a similar package for Julia in the future.