Merged
Conversation
Instead of invoking Gmsh, some canonical geometries are now meshed in CompScienceMeshes. Therefore, no difference between Windows and Linux is expected (as is in the case of Gmsh, which caused failing unit tests). TODO: - Sphere with Tetrahedrons - Disc (Triangles) - Torus (Triangles and Tetrahedrons)
- Merge the new primitives to the primitives directory - Also make meshrectangle incorporate the quadrilateral mesh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a bunch of canonical geometries that are now meshed in CompScienceMeshes (instead of Gmsh)
A key change is the introduction of primitives-directory and the splitting of the geometries into separate files as the primitives.jl would otherwise grow unbearably long.
For backwards compatibility, it is possible to use the old meshing strategy via generator=:gmsh as keyword argument.
Some of the interfaces are changed to be consistent (this pertains in particular meshrectangle).