Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that the code complexity shrinked with a switch to UUID ids and it will also allow for easier transition to slick. There is one potential drawback though.
Switch from strings to UUIDs makes error responses different in some cases. One example would be that where we first accepted
.as[String]every string would go in and after unsuccessful parsing to UUID we would send avnd.errresponse. After changing that matcher to.as[UUID]strings that won't match UUID format will simply become a 405 , not allowed, as they won't match any path. I left a TODO in two places in tests to point out if we want it this way or is there some change required.Additionally I have created a String extending method .uuid that will convert a string to a UUID object. It is only used for testing purposes (in tests and where we add dummy data to a
MemStorage). The problem with this method is that the potential exception it can throw will be only catched at runtime. I wonder if we can make compiler check all the strings using this method. I think this could be solved with macros. What do you think @jczuchnowski ?