Conversation
8606308 to
822fd90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
await usingsyntax support (Node.js ≥20) for RAII-style automatic lock cleanup. Lock handles now implementSymbol.asyncDispose, ensuring cleanup on all code paths including early returns and exceptions.Key Changes
AsyncDisposable Implementation (
common/disposable.ts)decorateAcquireResult()decorator adds disposal support to all acquire operationsdisposeTimeoutMs) for unreliable network environmentsonReleaseErrorcallback (never throw)Default Error Observability
console.errorfor visibilitySYNCGUARD_DEBUG=trueBackend Integration
BackendConfignow acceptsonReleaseErroranddisposeTimeoutMsoptionsUpdated Documentation
await usingas primary patternUsage Patterns
Modern (Node.js ≥20) - Recommended
Legacy (Node.js <20) - Still supported
Error Handling Configuration
Testing
test/integration/disposable.test.tstest/unit/disposable.test.tsArchitectural Decision
See ADR-015 (Async RAII for Locks) and ADR-016 (Opt-In Disposal Timeout) in
specs/adrs.mdfor design rationale.Credits
Thanks to @alii for proposing the
await usingAPI!