Conversation
- Refactor Promise.race() to handle slow in-flight gRPC calls - Pre-attach error handler to catch late rejections from aborted promises - Add Firestore emulator health check to CI workflow - Adjust test timeouts for Firestore emulator reliability - Enhance documentation of timeout behavior across backends This ensures disposal never blocks indefinitely while allowing background RPCs to complete naturally. Errors from delayed operations are routed through onReleaseError callback for observability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored Promise.race() logic to handle slow in-flight gRPC calls and improve Firestore disposal reliability:
This ensures disposal never blocks indefinitely while allowing background RPCs to complete naturally. Errors from delayed operations are routed through onReleaseError callback for observability.
Changes
Test Plan