Conversation
- Remove unnecessary catch-rethrow in auto-lock try/finally - Add 6 tests for release failure handling: - Result preservation when release fails - Default error handler logging - Custom onReleaseError callback invocation - Non-Error normalization with originalError - Callback error swallowing - Function error propagation with release failure
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (77.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 75.88% 76.37% +0.49%
==========================================
Files 42 42
Lines 2658 2688 +30
==========================================
+ Hits 2017 2053 +36
+ Misses 641 635 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Rename misleading "should handle lookup consistently within tolerance window" to "should return lock info for active lock" - Move Storage Key Consistency tests from E2E to new crypto.test.ts - Add comprehensive unit tests for generateLockId, hashKey, formatFence
- Track pending release() operations so dispose() can wait for them - Handle synchronous throws from backend.release() - Add runtime validation to acquireHandle() for misconfigured backends
- Add tests for disposal timeout edge cases (release fails before/after timeout) - Add test for acquireHandle success path - Add deterministic jitter tests using mocked Math.random and setTimeout - Add test for retryDelay <= 0 timeout edge case Coverage: disposable.ts 100%, auto-lock.ts 99.34%
Firestore emulator can be slow to fully initialize in CI, causing tests to hang for 5+ minutes. Adding explicit per-test timeouts ensures fast failure with actionable error messages.
- Use OIDC token instead of secret for codecov uploads - Add 5s warmup delay after Firestore emulator port check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispose()returnednullwhen called whilerelease()was awaiting backendbackend.release()to prevent state getting stuck at "disposing"acquireHandle()for misconfigured backends/mocksChanges
common/disposable.tspendingReleasepromise sodispose()can wait for in-flightrelease()operationsbackend.release()call to handle synchronous throwsacquireHandle()Tests Added